Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7432)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.h

Issue 2603433002: Move SecurityInterstitialPage into component (Closed)
Patch Set: missed some changes in rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.h
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.h b/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
index a302b93334b89c1e533807d9c3e4f3f5233157e1..93ce1114be7947a456641d41fc9891a383b66ba4 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
@@ -38,8 +38,8 @@
#include "base/macros.h"
#include "base/task/cancelable_task_tracker.h"
#include "chrome/browser/interstitials/chrome_metrics_helper.h"
-#include "chrome/browser/interstitials/security_interstitial_page.h"
#include "chrome/browser/safe_browsing/ui_manager.h"
+#include "components/security_interstitials/content/security_interstitial_page.h"
#include "components/security_interstitials/core/safe_browsing_error_ui.h"
#include "content/public/browser/interstitial_page_delegate.h"
#include "url/gurl.h"
@@ -49,7 +49,8 @@ namespace safe_browsing {
class SafeBrowsingBlockingPageFactory;
class ThreatDetails;
-class SafeBrowsingBlockingPage : public SecurityInterstitialPage {
+class SafeBrowsingBlockingPage
+ : public security_interstitials::SecurityInterstitialPage {
public:
typedef security_interstitials::UnsafeResource UnsafeResource;
typedef security_interstitials::SafeBrowsingErrorUI SafeBrowsingErrorUI;
@@ -130,12 +131,7 @@ class SafeBrowsingBlockingPage : public SecurityInterstitialPage {
// milliseconds), in order to get data from the blocked resource itself.
int64_t threat_details_proceed_delay_ms_;
- // Checks if we should even show the extended reporting option. We don't show
- // it in incognito mode or if kSafeBrowsingExtendedReportingOptInAllowed
- // preference is disabled.
- bool CanShowExtendedReportingOption();
-
- // Called when the insterstitial is going away. If there is a
+ // Called when the interstitial is going away. If there is a
// pending threat details object, we look at the user's
// preferences, and if the option to send threat details is
// enabled, the report is scheduled to be sent on the |ui_manager_|.
@@ -194,7 +190,8 @@ class SafeBrowsingBlockingPage : public SecurityInterstitialPage {
static SafeBrowsingErrorUI::SBInterstitialReason GetInterstitialReason(
const UnsafeResourceList& unsafe_resources);
- static std::unique_ptr<ChromeMetricsHelper> CreateMetricsHelper(
+ std::unique_ptr<security_interstitials::SecurityInterstitialControllerClient>
+ CreateControllerClient(
content::WebContents* web_contents,
const UnsafeResourceList& unsafe_resources);
« no previous file with comments | « chrome/browser/policy/policy_browsertest.cc ('k') | chrome/browser/safe_browsing/safe_browsing_blocking_page.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698