Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: third_party/WebKit/Source/core/input/MouseEventManager.cpp

Issue 2603413002: Improve drag-and-drop comment in MouseEventManager. (Closed)
Patch Set: Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/input/MouseEventManager.cpp
diff --git a/third_party/WebKit/Source/core/input/MouseEventManager.cpp b/third_party/WebKit/Source/core/input/MouseEventManager.cpp
index d377ff2b423022d1734cdc75bcfb814c27e0beca..da2fdc0a8a78bdcbc0a56a3daa86e3d5103e630e 100644
--- a/third_party/WebKit/Source/core/input/MouseEventManager.cpp
+++ b/third_party/WebKit/Source/core/input/MouseEventManager.cpp
@@ -901,8 +901,7 @@ void MouseEventManager::dragSourceEndedAt(const PlatformMouseEvent& event,
DragOperation operation) {
if (dragState().m_dragSrc) {
dragState().m_dragDataTransfer->setDestinationOperation(operation);
- // For now we don't care if event handler cancels default behavior, since
- // there is none.
+ // The return value is ignored because dragend is not cancelable.
dispatchDragSrcEvent(EventTypeNames::dragend, event);
}
clearDragDataTransfer();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698