Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: runtime/vm/scopes.cc

Issue 2603383004: Sane asynchronous debugging and stack traces (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/raw_object.h ('k') | runtime/vm/service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/scopes.cc
diff --git a/runtime/vm/scopes.cc b/runtime/vm/scopes.cc
index 75f5d688bf59de6de2765c8cbac70974820850f5..d75d4ca943c832a93996d40542b8974532350788 100644
--- a/runtime/vm/scopes.cc
+++ b/runtime/vm/scopes.cc
@@ -261,7 +261,19 @@ int LocalScope::AllocateVariables(int first_parameter_index,
static bool IsFilteredIdentifier(const String& str) {
ASSERT(str.Length() > 0);
if (str.raw() == Symbols::AsyncOperation().raw()) {
- // Keep :async_op for asynchronous debugging.
+ // Keep :async_op for await debugging.
+ return false;
+ }
+ if (str.raw() == Symbols::AsyncCompleter().raw()) {
+ // Keep :async_completer for await debugging.
+ return false;
+ }
+ if (str.raw() == Symbols::ControllerStream().raw()) {
+ // Keep :controller_sstream for await debugging.
+ return false;
+ }
+ if (str.raw() == Symbols::AwaitJumpVar().raw()) {
+ // Keep :await_jump_for for await debugging.
return false;
}
return str.CharAt(0) == ':';
« no previous file with comments | « runtime/vm/raw_object.h ('k') | runtime/vm/service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698