Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: ui/views/controls/button/custom_button.cc

Issue 2603373002: Show/hide ink drop highlight when button enable state changes. (Closed)
Patch Set: Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/controls/button/custom_button_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/button/custom_button.cc
diff --git a/ui/views/controls/button/custom_button.cc b/ui/views/controls/button/custom_button.cc
index 21ebca3d538420116b4a012c0720d365c4a5612d..115dcb4b486be897aa89d77250af8ee40d0c7e31 100644
--- a/ui/views/controls/button/custom_button.cc
+++ b/ui/views/controls/button/custom_button.cc
@@ -139,6 +139,7 @@ void CustomButton::OnEnabledChanged() {
GetInkDrop()->SetHovered(should_enter_hover_state);
} else {
SetState(STATE_DISABLED);
+ GetInkDrop()->SetHovered(false);
sadrul 2017/01/03 17:13:25 Can some of these move into CustomButton::StateCha
bruthig 2017/01/03 20:05:21 Would it make more sense to move this to InkDropHo
Evan Stade 2017/01/03 21:19:38 I don't know, maybe, but I'd rather keep it near t
Evan Stade 2017/01/03 21:19:38 Not easily. For one thing, all the 19 overrides wo
}
}
« no previous file with comments | « no previous file | ui/views/controls/button/custom_button_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698