Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 260333004: Re-enabling WebRTC HD cam tests after Logitech C920 fix. (Closed)

Created:
6 years, 7 months ago by phoglund_chromium
Modified:
6 years, 7 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Visibility:
Public.

Description

Re-enabling WebRTC HD cam tests after Logitech C920 fix. Also doing some light refactoring to make the code cleaner. BUG=360512 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266893

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Did some light refactoring to clean up the code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -32 lines) Patch
M chrome/browser/media/chrome_webrtc_webcam_browsertest.cc View 1 2 2 chunks +21 lines, -32 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
phoglund_chromium
6 years, 7 months ago (2014-04-29 13:11:50 UTC) #1
tommi (sloooow) - chröme
lgtm
6 years, 7 months ago (2014-04-29 15:08:39 UTC) #2
phoglund_chromium
The CQ bit was checked by phoglund@chromium.org
6 years, 7 months ago (2014-04-29 15:34:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/260333004/40001
6 years, 7 months ago (2014-04-29 15:34:56 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 15:35:34 UTC) #5
Message was sent while issue was closed.
Change committed as 266893

Powered by Google App Engine
This is Rietveld 408576698