Disable tracking of visits to bookmarks in incognito

Disable tracking of visits to bookmarks in incognito

Date of the last visit to any bookmarked page is stored to
BookmarkModel. Previously, this happens in off-the-record profiles as
well. This CL fixes the issue.

BUG=662382
Had to manually resolve (trivial) conflicts within drover when merging to M56, so I add TBR.

TBR=avi@chromium.org,bauerb@chromium.org,battre@chromium.org

Review-Url: https://codereview.chromium.org/2572433002
Cr-Commit-Position: refs/heads/master@{#438845}
(cherry picked from commit 1e385fa1c19d96f343594a0623a7985adb50c483)

Committed: https://chromium.googlesource.com/chromium/src/+/62f09cadded58c144c804dfacf0ef7305247ad90

[jkrcal, 2017-01-02 11:50:02]

Description was changed from

==========
Disable tracking of visits to bookmarks in incognito

Date of the last visit to any bookmarked page is stored to
BookmarkModel. Previously, this happens in off-the-record profiles as
well. This CL fixes the issue.

BUG=662382

Review-Url: https://codereview.chromium.org/2572433002
Cr-Commit-Position: refs/heads/master@{#438845}
(cherry picked from commit 1e385fa1c19d96f343594a0623a7985adb50c483)
==========

to

==========
Disable tracking of visits to bookmarks in incognito

Date of the last visit to any bookmarked page is stored to
BookmarkModel. Previously, this happens in off-the-record profiles as
well. This CL fixes the issue.

BUG=662382

Review-Url: https://codereview.chromium.org/2572433002
Cr-Commit-Position: refs/heads/master@{#438845}
(cherry picked from commit 1e385fa1c19d96f343594a0623a7985adb50c483)

Committed:
https://chromium.googlesource.com/chromium/src/+/62f09cadded58c144c804dfacf0e...
==========

[jkrcal, 2017-01-02 11:50:03]

Committed patchset #1 (id:1) manually as
62f09cadded58c144c804dfacf0ef7305247ad90.

[jkrcal, 2017-01-02 11:56:19]

Description was changed from

==========
Disable tracking of visits to bookmarks in incognito

Date of the last visit to any bookmarked page is stored to
BookmarkModel. Previously, this happens in off-the-record profiles as
well. This CL fixes the issue.

BUG=662382

Review-Url: https://codereview.chromium.org/2572433002
Cr-Commit-Position: refs/heads/master@{#438845}
(cherry picked from commit 1e385fa1c19d96f343594a0623a7985adb50c483)

Committed:
https://chromium.googlesource.com/chromium/src/+/62f09cadded58c144c804dfacf0e...
==========

to

==========
Disable tracking of visits to bookmarks in incognito

Date of the last visit to any bookmarked page is stored to
BookmarkModel. Previously, this happens in off-the-record profiles as
well. This CL fixes the issue.

BUG=662382

Had to manually resolve (trivial) conflicts within drover when merging to M56,
so I add TBR.

TBR=avi@chromium.org,bauerb@chromium.org,battre@chromium.org

Review-Url: https://codereview.chromium.org/2572433002
Cr-Commit-Position: refs/heads/master@{#438845}
(cherry picked from commit 1e385fa1c19d96f343594a0623a7985adb50c483)

Committed:
https://chromium.googlesource.com/chromium/src/+/62f09cadded58c144c804dfacf0e...
==========

[jkrcal, 2017-01-02 11:59:28]

jkrcal@chromium.org changed reviewers:
+ avi@chromium.org, battre@chromium.org, bauerb@chromium.org

[jkrcal, 2017-01-02 11:59:28]

Heads-up: I manually resolved conflicts when merging to M56.

(I added TBR= info after landing this merged-to-m56 CL;
to be on the safe side, I send out the heads-up manually.)

[jkrcal, 2017-01-03 09:19:15]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2606283003/ by jkrcal@chromium.org.

The reason for reverting is: bookmark_last_visit_updater_unittest.cc does not
compile on the M56 branch. 

Signature of one function that I use in the unit-test is different from the one
on trunk, I need to fix it..