Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2603063002: Only clear tooltip message on a user scroll or compositor scroll. (Closed)
Patch Set: Fix PLSA logic to include frame scrolls Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@gmail.com> 10 * Christian Biesinger <cbiesinger@gmail.com>
(...skipping 395 matching lines...) Expand 10 before | Expand all | Expand 10 after
406 406
407 FloatQuad quadForFakeMouseMoveEvent = FloatQuad(FloatRect( 407 FloatQuad quadForFakeMouseMoveEvent = FloatQuad(FloatRect(
408 layer()->layoutObject()->previousVisualRectIncludingCompositedScrolling( 408 layer()->layoutObject()->previousVisualRectIncludingCompositedScrolling(
409 paintInvalidationContainer))); 409 paintInvalidationContainer)));
410 410
411 quadForFakeMouseMoveEvent = 411 quadForFakeMouseMoveEvent =
412 paintInvalidationContainer.localToAbsoluteQuad(quadForFakeMouseMoveEvent); 412 paintInvalidationContainer.localToAbsoluteQuad(quadForFakeMouseMoveEvent);
413 frame->eventHandler().dispatchFakeMouseMoveEventSoonInQuad( 413 frame->eventHandler().dispatchFakeMouseMoveEventSoonInQuad(
414 quadForFakeMouseMoveEvent); 414 quadForFakeMouseMoveEvent);
415 415
416 Page* page = frame->page(); 416 if (scrollType == UserScroll || scrollType == CompositorScroll) {
417 if (page) 417 Page* page = frame->page();
418 page->chromeClient().clearToolTip(*frame); 418 if (page)
419 page->chromeClient().clearToolTip(*frame);
420 }
419 421
420 bool requiresPaintInvalidation = true; 422 bool requiresPaintInvalidation = true;
421 423
422 if (box().view()->compositor()->inCompositingMode()) { 424 if (box().view()->compositor()->inCompositingMode()) {
423 bool onlyScrolledCompositedLayers = 425 bool onlyScrolledCompositedLayers =
424 scrollsOverflow() && layer()->isAllScrollingContentComposited() && 426 scrollsOverflow() && layer()->isAllScrollingContentComposited() &&
425 box().style()->backgroundLayers().attachment() != 427 box().style()->backgroundLayers().attachment() !=
426 LocalBackgroundAttachment; 428 LocalBackgroundAttachment;
427 429
428 if (usesCompositedScrolling() || onlyScrolledCompositedLayers) 430 if (usesCompositedScrolling() || onlyScrolledCompositedLayers)
(...skipping 1643 matching lines...) Expand 10 before | Expand all | Expand 10 after
2072 2074
2073 void PaintLayerScrollableArea::DelayScrollOffsetClampScope:: 2075 void PaintLayerScrollableArea::DelayScrollOffsetClampScope::
2074 clampScrollableAreas() { 2076 clampScrollableAreas() {
2075 for (auto& scrollableArea : *s_needsClamp) 2077 for (auto& scrollableArea : *s_needsClamp)
2076 scrollableArea->clampScrollOffsetAfterOverflowChange(); 2078 scrollableArea->clampScrollOffsetAfterOverflowChange();
2077 delete s_needsClamp; 2079 delete s_needsClamp;
2078 s_needsClamp = nullptr; 2080 s_needsClamp = nullptr;
2079 } 2081 }
2080 2082
2081 } // namespace blink 2083 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698