Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js

Issue 2603053002: [Devtools] Type externs global namespaces (Closed)
Patch Set: Merge branch 'master' into TYPE_EXTERN_GLOBALS Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/externs.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js
diff --git a/third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js b/third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js
index 56aac0ccf049102d266bc8b9ffa432079bde1721..aa0168a8ec215b41113e844aa554323dec5c780a 100644
--- a/third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js
+++ b/third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js
@@ -76,8 +76,9 @@ Components.JavaScriptAutocomplete.completionsForExpression = function(expression
var fufill;
var promise = new Promise(x => fufill = x);
- if (!expressionString && executionContext.debuggerModel.selectedCallFrame())
- variableNamesInScopes(executionContext.debuggerModel.selectedCallFrame(), receivedPropertyNames);
+ var selectedFrame = executionContext.debuggerModel.selectedCallFrame();
+ if (!expressionString && selectedFrame)
+ variableNamesInScopes(selectedFrame, receivedPropertyNames);
else
executionContext.evaluate(expressionString, 'completion', true, true, false, false, false, evaluated);
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/externs.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698