Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Side by Side Diff: runtime/vm/compiler.cc

Issue 2602913002: Get rid of unused field has_compiled_code_ from the Isolate structure. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/vm/isolate.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/compiler.h" 5 #include "vm/compiler.h"
6 6
7 #include "vm/assembler.h" 7 #include "vm/assembler.h"
8 8
9 #include "vm/ast_printer.h" 9 #include "vm/ast_printer.h"
10 #include "vm/block_scheduler.h" 10 #include "vm/block_scheduler.h"
(...skipping 1143 matching lines...) Expand 10 before | Expand all | Expand 10 after
1154 FinalizeCompilation(&assembler, &graph_compiler, flow_graph); 1154 FinalizeCompilation(&assembler, &graph_compiler, flow_graph);
1155 } 1155 }
1156 // TODO(srdjan): Enable this and remove the one from 1156 // TODO(srdjan): Enable this and remove the one from
1157 // 'BackgroundCompiler::CompileOptimized' once cause of time-outs 1157 // 'BackgroundCompiler::CompileOptimized' once cause of time-outs
1158 // is resolved. 1158 // is resolved.
1159 // if (isolate()->heap()->NeedsGarbageCollection()) { 1159 // if (isolate()->heap()->NeedsGarbageCollection()) {
1160 // isolate()->heap()->CollectAllGarbage(); 1160 // isolate()->heap()->CollectAllGarbage();
1161 // } 1161 // }
1162 } 1162 }
1163 } 1163 }
1164 // Mark that this isolate now has compiled code.
1165 isolate()->set_has_compiled_code(true);
1166 // Exit the loop and the function with the correct result value. 1164 // Exit the loop and the function with the correct result value.
1167 is_compiled = true; 1165 is_compiled = true;
1168 done = true; 1166 done = true;
1169 } else { 1167 } else {
1170 // We bailed out or we encountered an error. 1168 // We bailed out or we encountered an error.
1171 const Error& error = Error::Handle(thread()->sticky_error()); 1169 const Error& error = Error::Handle(thread()->sticky_error());
1172 1170
1173 if (error.raw() == Object::branch_offset_error().raw()) { 1171 if (error.raw() == Object::branch_offset_error().raw()) {
1174 // Compilation failed due to an out of range branch offset in the 1172 // Compilation failed due to an out of range branch offset in the
1175 // assembler. We try again (done = false) with far branches enabled. 1173 // assembler. We try again (done = false) with far branches enabled.
(...skipping 1140 matching lines...) Expand 10 before | Expand all | Expand 10 after
2316 2314
2317 2315
2318 bool BackgroundCompiler::IsDisabled() { 2316 bool BackgroundCompiler::IsDisabled() {
2319 UNREACHABLE(); 2317 UNREACHABLE();
2320 return true; 2318 return true;
2321 } 2319 }
2322 2320
2323 #endif // DART_PRECOMPILED_RUNTIME 2321 #endif // DART_PRECOMPILED_RUNTIME
2324 2322
2325 } // namespace dart 2323 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698