Speed up _wouldBeTooManyUsers.

Speed up _wouldBeTooManyUsers.

On my current dart-program, this reduced compilation time by a third.

$ # before applying the patch:
$ time sdk/bin/dart2js --packages=sdk/.packages --out=/tmp/foo.js /tmp/bug2.dart
Dart file (/tmp/bug2.dart) compiled to JavaScript: /tmp/foo.js

real    0m29.859s
user    0m33.931s
sys     0m1.530s

$ time sdk/bin/dart2js --packages=sdk/.packages --out=/tmp/foo.js /tmp/bug2.dart
Dart file (/tmp/bug2.dart) compiled to JavaScript: /tmp/foo.js

real    0m30.062s
user    0m34.012s
sys     0m1.558s

$ # ----------------- apply the patch.
$ git stash pop

$ time sdk/bin/dart2js --packages=sdk/.packages --out=/tmp/foo.js /tmp/bug2.dart
Dart file (/tmp/bug2.dart) compiled to JavaScript: /tmp/foo.js

real    0m20.782s
user    0m24.540s
sys     0m1.750s

$ time sdk/bin/dart2js --packages=sdk/.packages --out=/tmp/foo.js /tmp/bug2.dart
Dart file (/tmp/bug2.dart) compiled to JavaScript: /tmp/foo.js

real    0m21.042s
user    0m24.495s
sys     0m2.173s

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/968fcc5c625a1af8b9b061b4fb150772eb92f4fa

[floitsch, 2016-12-28 15:37:28]

floitsch@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-12-28 15:44:08]

lgtm, thanks!

[floitsch, 2016-12-29 13:40:50]

Description was changed from

==========
Speed up _wouldBeTooManyUsers.

On my current dart-program, this reduced compilation time by a third.

$ # before applying the patch:
$ time sdk/bin/dart2js --packages=sdk/.packages --out=/tmp/foo.js /tmp/bug2.dart
Dart file (/tmp/bug2.dart) compiled to JavaScript: /tmp/foo.js

real    0m29.859s
user    0m33.931s
sys     0m1.530s

$ time sdk/bin/dart2js --packages=sdk/.packages --out=/tmp/foo.js /tmp/bug2.dart
Dart file (/tmp/bug2.dart) compiled to JavaScript: /tmp/foo.js

real    0m30.062s
user    0m34.012s
sys     0m1.558s

$ # ----------------- apply the patch.
$ git stash pop

$ time sdk/bin/dart2js --packages=sdk/.packages --out=/tmp/foo.js /tmp/bug2.dart
Dart file (/tmp/bug2.dart) compiled to JavaScript: /tmp/foo.js

real    0m20.782s
user    0m24.540s
sys     0m1.750s

$ time sdk/bin/dart2js --packages=sdk/.packages --out=/tmp/foo.js /tmp/bug2.dart
Dart file (/tmp/bug2.dart) compiled to JavaScript: /tmp/foo.js

real    0m21.042s
user    0m24.495s
sys     0m2.173s

BUG=
==========

to

==========
Speed up _wouldBeTooManyUsers.

On my current dart-program, this reduced compilation time by a third.

$ # before applying the patch:
$ time sdk/bin/dart2js --packages=sdk/.packages --out=/tmp/foo.js /tmp/bug2.dart
Dart file (/tmp/bug2.dart) compiled to JavaScript: /tmp/foo.js

real    0m29.859s
user    0m33.931s
sys     0m1.530s

$ time sdk/bin/dart2js --packages=sdk/.packages --out=/tmp/foo.js /tmp/bug2.dart
Dart file (/tmp/bug2.dart) compiled to JavaScript: /tmp/foo.js

real    0m30.062s
user    0m34.012s
sys     0m1.558s

$ # ----------------- apply the patch.
$ git stash pop

$ time sdk/bin/dart2js --packages=sdk/.packages --out=/tmp/foo.js /tmp/bug2.dart
Dart file (/tmp/bug2.dart) compiled to JavaScript: /tmp/foo.js

real    0m20.782s
user    0m24.540s
sys     0m1.750s

$ time sdk/bin/dart2js --packages=sdk/.packages --out=/tmp/foo.js /tmp/bug2.dart
Dart file (/tmp/bug2.dart) compiled to JavaScript: /tmp/foo.js

real    0m21.042s
user    0m24.495s
sys     0m2.173s

BUG=
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/968fcc5c625a1af8b9b061b4fb150772eb92f4fa
==========

[floitsch, 2016-12-29 13:40:51]

Committed patchset #2 (id:20001) manually as
968fcc5c625a1af8b9b061b4fb150772eb92f4fa (presubmit successful).