Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 260283002: Use mDns in browser process, without sandboxed utility process/ (Closed)

Created:
6 years, 7 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Use mDns in browser process, without sandboxed utility process. It still uses utility process if firewall rules are not installed, which is common for user-level installs. BUG=366408, 349645 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267119

Patch Set 1 #

Total comments: 2

Patch Set 2 : Tue 04/29/2014 10:18:35.18 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -2 lines) Patch
M chrome/browser/local_discovery/service_discovery_shared_client.cc View 2 chunks +41 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 7 months ago (2014-04-29 06:02:48 UTC) #1
Vitaly Buka (NO REVIEWS)
+asvitkine for histograms
6 years, 7 months ago (2014-04-29 06:26:23 UTC) #2
Alexei Svitkine (slow)
https://codereview.chromium.org/260283002/diff/80001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/260283002/diff/80001/tools/metrics/histograms/histograms.xml#newcode8578 tools/metrics/histograms/histograms.xml:8578: + Reports whether a firewall is set so we ...
6 years, 7 months ago (2014-04-29 13:26:12 UTC) #3
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/260283002/diff/80001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/260283002/diff/80001/tools/metrics/histograms/histograms.xml#newcode8578 tools/metrics/histograms/histograms.xml:8578: + Reports whether a firewall is set so we ...
6 years, 7 months ago (2014-04-29 17:20:10 UTC) #4
Noam Samuel
lgtm
6 years, 7 months ago (2014-04-29 19:08:24 UTC) #5
Alexei Svitkine (slow)
lgtm
6 years, 7 months ago (2014-04-29 19:09:10 UTC) #6
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 7 months ago (2014-04-29 21:49:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/260283002/120001
6 years, 7 months ago (2014-04-29 21:50:43 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 07:27:24 UTC) #9
Message was sent while issue was closed. 
Change committed as 267119

Powered by Google App Engine
This is Rietveld 408576698