Add flutter_engine runtime to the test script so we can run standard dart tests from the test suite…

tools/testing/dart/runtime_configuration.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library runtime_configuration;
 
 import 'dart:io' show Directory, File;
 
 import 'compiler_configuration.dart' show CommandArtifact;
 
@@ skipping 40 matching lines @@
 
       case 'd8':
         return new D8RuntimeConfiguration();
 
       case 'none':
         return new NoneRuntimeConfiguration();
 
       case 'vm':
         return new StandaloneDartRuntimeConfiguration();
 
+      case 'flutter_engine':
+        return new StandaloneFlutterEngineConfiguration();
+
       case 'dart_precompiled':
         if (configuration['system'] == 'android') {
           return new DartPrecompiledAdbRuntimeConfiguration(useBlobs: useBlobs);
         }
         return new DartPrecompiledRuntimeConfiguration(useBlobs: useBlobs);
 
       case 'drt':
         return new DrtRuntimeConfiguration();
 
       case 'self_check':
@@ skipping 162 matching lines @@
     }
     String executable = suite.configuration['noopt']
         ? suite.dartVmNooptBinaryFileName
         : suite.dartVmBinaryFileName;
     return <Command>[
       commandBuilder.getVmCommand(executable, arguments, environmentOverrides)
     ];
   }
 }
 
+/// The flutter engine binary, "sky_shell".
+class StandaloneFlutterEngineConfiguration extends DartVmRuntimeConfiguration {
+  List<Command> computeRuntimeCommands(
+      TestSuite suite,
+      CommandBuilder commandBuilder,
+      CommandArtifact artifact,
+      List<String> arguments,
+      Map<String, String> environmentOverrides) {
+    String script = artifact.filename;
+    String type = artifact.mimeType;
+    if (script != null &&
+        type != 'application/dart' &&
+        type != 'application/dart-snapshot') {
+      throw "Flutter Engine cannot run files of type '$type'.";
+    }
+    String executable = suite.skyBinaryFileName;
+    var args = new List();

[Bill Hesse, 2017/01/05 17:48:33]

I see this is just copied from other cases, but surely

var args = <String>['--non-interactive']..addAll(arguments);

is better.

[siva, 2017/01/05 20:38:45]

Done.

+    args.add('--non-interactive');
+    args.addAll(arguments);
+    return <Command>[
+      commandBuilder.getVmCommand(executable, args, environmentOverrides)
+    ];
+  }
+}
+
 class DartPrecompiledRuntimeConfiguration extends DartVmRuntimeConfiguration {
   final bool useBlobs;
   DartPrecompiledRuntimeConfiguration({bool useBlobs}) : useBlobs = useBlobs;
 
   List<Command> computeRuntimeCommands(
       TestSuite suite,
       CommandBuilder commandBuilder,
       CommandArtifact artifact,
       List<String> arguments,
       Map<String, String> environmentOverrides) {
@@ skipping 87 matching lines @@
 class DummyRuntimeConfiguration extends DartVmRuntimeConfiguration {
   List<Command> computeRuntimeCommands(
       TestSuite suite,
       CommandBuilder commandBuilder,
       CommandArtifact artifact,
       List<String> arguments,
       Map<String, String> environmentOverrides) {
     throw "Unimplemented runtime '$runtimeType'";
   }
 }