Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 260263002: Merge three implementations for getting the topmost x11 window at a point (Closed)

Created:
6 years, 7 months ago by pkotwicz
Modified:
6 years, 7 months ago
Reviewers:
sadrul, Elliot Glaysher, sky
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org, dcheng
Visibility:
Public.

Description

Introduce X11TopmostWindowFinder which merges the mostly duplicated functionality to find the topmost window at a point in: - window_finder_x11.cc - desktop_drag_drop_client_aurax11.cc - desktop_screen_x11.cc Having all of the similar functionality in one place will be helpful for testing BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268001

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -276 lines) Patch
M chrome/browser/ui/views/tabs/window_finder_x11.cc View 3 chunks +4 lines, -169 lines 0 comments Download
M ui/views/views.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc View 4 chunks +7 lines, -57 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11.cc View 3 chunks +3 lines, -50 lines 0 comments Download
A ui/views/widget/desktop_aura/x11_topmost_window_finder.h View 1 chunk +53 lines, -0 lines 0 comments Download
A ui/views/widget/desktop_aura/x11_topmost_window_finder.cc View 1 chunk +78 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
pkotwicz
Sadrul, PTAL I am planning on adding tests for this class in my next CL. ...
6 years, 7 months ago (2014-04-29 02:27:46 UTC) #1
sadrul
+erg@
6 years, 7 months ago (2014-04-30 19:38:41 UTC) #2
Elliot Glaysher
This is something I've wanted done for a long time. Thank you for doing this. ...
6 years, 7 months ago (2014-04-30 19:45:55 UTC) #3
pkotwicz
Scott can you please take a look at the change in chrome/browser/ui/views/tabs
6 years, 7 months ago (2014-04-30 20:36:19 UTC) #4
sky
Nice, LGTM
6 years, 7 months ago (2014-04-30 21:21:12 UTC) #5
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 7 months ago (2014-05-02 21:22:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/260263002/30001
6 years, 7 months ago (2014-05-02 21:23:51 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-03 02:07:49 UTC) #8
Message was sent while issue was closed.
Change committed as 268001

Powered by Google App Engine
This is Rietveld 408576698