Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Issue 2602593002: [chrome.dial] [WIP] Adds an API to get the active network ID. (Closed)

Created:
3 years, 12 months ago by mark a. foltz
Modified:
3 years, 7 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds an onNetworkIdChanged event handler to chrome.dial that informs callers when there is a change to the set of networks being used for local discovery. BUG=

Patch Set 1 #

Patch Set 2 : Outline API #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -0 lines) Patch
M chrome/browser/extensions/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/dial/dial_api.h View 1 2 chunks +19 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/dial/dial_api.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/dial/discovery_network_monitor.h View 1 1 chunk +84 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/dial/discovery_network_monitor.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/dial.idl View 1 4 chunks +23 lines, -0 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
mark a. foltz
PTAL at the overall design and provide any feedback before implementation proceeds. The implementation will ...
3 years, 12 months ago (2016-12-27 23:19:56 UTC) #3
mark a. foltz
3 years, 7 months ago (2017-05-04 23:35:16 UTC) #4
This has been taken over here: https://codereview.chromium.org/2750453002

Powered by Google App Engine
This is Rietveld 408576698