third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp - Issue 2602523002: [Presentation API] Resolve PresentationRequest::reconnect() with existing presentation connection i…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp

Issue 2602523002: [Presentation API] Resolve PresentationRequest::reconnect() with existing presentation connection i… (Closed)

Patch Set: remove getExecutionContext() null check in PresentationRequest::reconnect() Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp ('k') | third_party/WebKit/Source/modules/presentation/PresentationController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp b/third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp

index 8de07df2ffd49db35709cf8c24c0dc6e8d4b0b0d..30c89bb1c5090ddda6219a54eea174d9554cc423 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp

+++ b/third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp

@@ -26,8 +26,9 @@ PresentationConnectionCallbacks::PresentationConnectionCallbacks(

void PresentationConnectionCallbacks::onSuccess(

const WebPresentationSessionInfo& sessionInfo) {

if (!m_resolver->getExecutionContext() ||

- m_resolver->getExecutionContext()->isContextDestroyed())

+ m_resolver->getExecutionContext()->isContextDestroyed()) {

return;

+ }

m_resolver->resolve(

PresentationConnection::take(m_resolver.get(), sessionInfo, m_request));

}