third_party/WebKit/Source/modules/presentation/PresentationConnection.h - Issue 2602523002: [Presentation API] Resolve PresentationRequest::reconnect() with existing presentation connection i…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationConnection.h

Issue 2602523002: [Presentation API] Resolve PresentationRequest::reconnect() with existing presentation connection i… (Closed)

Patch Set: remove getExecutionContext() null check in PresentationRequest::reconnect() Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/presentation/ExistingPresentationConnectionCallbacks.cpp ('k') | third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationConnection.h

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationConnection.h b/third_party/WebKit/Source/modules/presentation/PresentationConnection.h

index d09b9cdfe4b886c08c171feb6abf0e1162f7736b..b5cb2a837a33634f7e63f546c31146ae8f5783ba 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationConnection.h

+++ b/third_party/WebKit/Source/modules/presentation/PresentationConnection.h

@@ -73,6 +73,10 @@ class PresentationConnection final : public EventTargetWithInlineData,

// connection.

bool matches(const WebPresentationSessionInfo&) const;

+ // Returns true if this connection's id equals to |id| and its url equals to

+ // |url|.

+ bool matches(const String& id, const KURL&) const;

// Notifies the connection about its state change.

void didChangeState(WebPresentationConnectionState);

@@ -83,6 +87,8 @@ class PresentationConnection final : public EventTargetWithInlineData,

void didReceiveTextMessage(const String& message);

void didReceiveBinaryMessage(const uint8_t* data, size_t length);

+ WebPresentationConnectionState getState();

protected:

// EventTarget implementation.

void addedEventListener(const AtomicString& eventType,