bluetooth: Fix flaky bluetooth internals browser test.

chrome/browser/resources/bluetooth_internals/snackbar.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Javascript for Snackbar controls, served from chrome://bluetooth-internals/.
  */
 
 cr.define('snackbar', function() {
   /** @typedef {{
    *    message: string,
    *    type: string,
    *    actionText: (string|undefined),
    *    action: (function()|undefined)
    *  }}
    */
   var SnackbarOptions;
 
   /** @const {number} */ var SHOW_DURATION = 5000;
+  /** @const {number} */ var TRANSITION_DURATION = 225;
 
   /**
    * Enum of Snackbar types. Used by Snackbar to determine the styling for the
    * Snackbar.
    * @enum {string}
    */
   var SnackbarType = {
     INFO: 'info',
     SUCCESS: 'success',
     WARNING: 'warning',
@@ skipping 40 matching lines @@
       this.classList.add(options.type);
       this.actionLink_.textContent = options.actionText || 'Dismiss';
 
       this.actionLink_.addEventListener('click', function() {
         if (options.action) options.action();
         this.dismiss();
       }.bind(this));
     },
 
     /**
-     * Shows the Snackbar.
+     * Shows the Snackbar and dispatches the 'showed' event.
      */
     show: function() {
       this.classList.add('open');
       if (Snackbar.hasContentFocus_) this.startTimeout_();
       else this.stopTimeout_();
 
       document.addEventListener('contentfocus', this.boundStartTimeout_);
       document.addEventListener('contentblur', this.boundStopTimeout_);
+      this.dispatchEvent(new CustomEvent('showed'));
     },
 
     /**
      * Dismisses the Snackbar. Once the Snackbar is completely hidden, the
-     * 'dismissed' event is fired.
+     * 'dismissed' event is fired and the returned Promise is resolved. If the
+     * snackbar is already hidden, a resolved Promise is returned.
+     * @return {!Promise}
      */
     dismiss: function() {
-      this.addEventListener('webkitTransitionEnd', function(event) {
-        if (event.propertyName === 'transform')
-          this.dispatchEvent(new CustomEvent('dismissed'));
+      this.stopTimeout_();
+
+      if (!this.classList.contains('open')) return Promise.resolve();

[Dan Beam, 2017/01/04 22:28:59]

this differs from our clang-format rules and will eventually need to be split
into 2 lines

[mbrunson, 2017/01/05 01:03:27]

Done.

+
+      return new Promise(function(resolve) {
+        listenOnce(this, 'webkitTransitionEnd',
+            this.onTransitionEnd_(resolve).bind(this));

[Dan Beam, 2017/01/04 22:28:59]

why not just

listenOnce(this, 'webkitTransitionEnd', function() {
  this.dispatchEvent(new CustomEvent('dismissed'));
  resolve();
});

? why do you need onTransitionEnd_?

[mbrunson, 2017/01/05 01:03:27]

Done.

+
+        ensureTransitionEndEvent(this, TRANSITION_DURATION);
+        this.classList.remove('open');
+
+        document.removeEventListener('contentfocus', this.boundStartTimeout_);
+        document.removeEventListener('contentblur', this.boundStopTimeout_);
       }.bind(this));
-
-      ensureTransitionEndEvent(this, SHOW_DURATION);
-      this.classList.remove('open');
-
-      document.removeEventListener('contentfocus', this.boundStartTimeout_);
-      document.removeEventListener('contentblur', this.boundStopTimeout_);
     },
 
     /**
+     * Generates a function that dispatches the 'dismissed' event and removes
+     * itself from the webkitTransitionEnd event when called.
+     * @param {!function()} resolve Promise resolve function.
+     * @return {!function()} Function that is called on webkitTransitionEnd.
+     */
+    onTransitionEnd_: function(resolve) {
+      return function() {
+        this.dispatchEvent(new CustomEvent('dismissed'));
+        resolve();
+      };
+    },
+
+    /**
      * Starts the timeout for dismissing the Snackbar.
      * @private
      */
     startTimeout_: function() {
       this.timeoutId_ = setTimeout(function() {
         this.dismiss();
       }.bind(this), SHOW_DURATION);
     },
 
     /**
@@ skipping 88 matching lines @@
     }, 10);
   };
 
   /**
    * Dismisses the Snackbar currently showing.
    * @param {boolean} clearQueue If true, clears the Snackbar queue before
    *     dismissing.
    */
   Snackbar.dismiss = function(clearQueue) {
     if (clearQueue) Snackbar.queue_ = [];
-    if (Snackbar.current_) Snackbar.current_.dismiss();
+    if (Snackbar.current_) return Snackbar.current_.dismiss();
+    return Promise.resolve();
   };
 
 
 
   return {
     Snackbar: Snackbar,
     SnackbarType: SnackbarType,
   };
 });