Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issue 2602483002: [ash-md] Stacks child layers properly for sticky header rows (Closed)

Created:
3 years, 12 months ago by bruthig
Modified:
3 years, 12 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[ash-md] Stacks child layers properly for sticky header rows The CL implements sticky section header rows in VPN page. Care is taken to stack the rows with child controls that have layers below the sticky section header rows. BUG=664244 TEST=Run with --material-design-ink-drop-animation-speed=slow Touch a Wi-Fi connection row and while ripple is growing drag-scroll the list of connections up. Verify that the ripple is stacked below the Wi-Fi header row. Review-Url: https://codereview.chromium.org/2557333003 Cr-Commit-Position: refs/heads/master@{#438689} (cherry picked from commit cd9913053dc56f12271b0c73558635ffbc26c580) Committed: https://chromium.googlesource.com/chromium/src/+/7000b78c4fb63b02f48700904b8f6c44f828322c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -45 lines) Patch
M ash/common/system/chromeos/network/network_list_md.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/system/chromeos/network/vpn_list_view.cc View 2 chunks +1 line, -17 lines 0 comments Download
M ash/common/system/tray/tray_details_view.cc View 4 chunks +62 lines, -27 lines 0 comments Download
M ash/common/system/tray/tray_details_view_unittest.cc View 3 chunks +43 lines, -0 lines 0 comments Download
M ash/common/system/tray/tray_popup_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/common/system/tray/tray_popup_utils.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
bruthig
3 years, 12 months ago (2016-12-22 22:29:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7000b78c4fb63b02f48700904b8f6c44f828322c.

Powered by Google App Engine
This is Rietveld 408576698