Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2602473004: Offline Page Cache uses user interaction triggers for saving pages. (Closed)
Patch Set: Rebased and added the other missing histogram.xml entry... Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 1878 matching lines...) Expand 10 before | Expand all | Expand 10 after
1889 IDS_FLAGS_WEBRTC_H264_WITH_OPENH264_FFMPEG_DESCRIPTION, kOsDesktop, 1889 IDS_FLAGS_WEBRTC_H264_WITH_OPENH264_FFMPEG_DESCRIPTION, kOsDesktop,
1890 FEATURE_VALUE_TYPE(content::kWebRtcH264WithOpenH264FFmpeg)}, 1890 FEATURE_VALUE_TYPE(content::kWebRtcH264WithOpenH264FFmpeg)},
1891 #endif // ENABLE_WEBRTC && BUILDFLAG(RTC_USE_H264) && !MEDIA_DISABLE_FFMPEG 1891 #endif // ENABLE_WEBRTC && BUILDFLAG(RTC_USE_H264) && !MEDIA_DISABLE_FFMPEG
1892 #if defined(OS_ANDROID) 1892 #if defined(OS_ANDROID)
1893 {"offline-pages-ntp", IDS_FLAGS_NTP_OFFLINE_PAGES_NAME, 1893 {"offline-pages-ntp", IDS_FLAGS_NTP_OFFLINE_PAGES_NAME,
1894 IDS_FLAGS_NTP_OFFLINE_PAGES_DESCRIPTION, kOsAndroid, 1894 IDS_FLAGS_NTP_OFFLINE_PAGES_DESCRIPTION, kOsAndroid,
1895 FEATURE_VALUE_TYPE(chrome::android::kNTPOfflinePagesFeature)}, 1895 FEATURE_VALUE_TYPE(chrome::android::kNTPOfflinePagesFeature)},
1896 {"offlining-recent-pages", IDS_FLAGS_OFFLINING_RECENT_PAGES_NAME, 1896 {"offlining-recent-pages", IDS_FLAGS_OFFLINING_RECENT_PAGES_NAME,
1897 IDS_FLAGS_OFFLINING_RECENT_PAGES_DESCRIPTION, kOsAndroid, 1897 IDS_FLAGS_OFFLINING_RECENT_PAGES_DESCRIPTION, kOsAndroid,
1898 FEATURE_VALUE_TYPE(offline_pages::kOffliningRecentPagesFeature)}, 1898 FEATURE_VALUE_TYPE(offline_pages::kOffliningRecentPagesFeature)},
1899 {"offlining-use-navigation-triggers",
1900 IDS_FLAGS_OFFLINING_USES_NAVIGATION_TRIGGERS_NAME,
1901 IDS_FLAGS_OFFLINING_USES_NAVIGATION_TRIGGERS_DESCRIPTION, kOsAndroid,
1902 FEATURE_VALUE_TYPE(
1903 offline_pages::kOffliningUsesNavigationTriggersFeature)},
1899 {"offline-pages-ct", IDS_FLAGS_OFFLINE_PAGES_CT_NAME, 1904 {"offline-pages-ct", IDS_FLAGS_OFFLINE_PAGES_CT_NAME,
1900 IDS_FLAGS_OFFLINE_PAGES_CT_DESCRIPTION, kOsAndroid, 1905 IDS_FLAGS_OFFLINE_PAGES_CT_DESCRIPTION, kOsAndroid,
1901 FEATURE_VALUE_TYPE(offline_pages::kOfflinePagesCTFeature)}, 1906 FEATURE_VALUE_TYPE(offline_pages::kOfflinePagesCTFeature)},
1902 #endif // OS_ANDROID 1907 #endif // OS_ANDROID
1903 {"protect-sync-credential", IDS_FLAGS_PROTECT_SYNC_CREDENTIAL_NAME, 1908 {"protect-sync-credential", IDS_FLAGS_PROTECT_SYNC_CREDENTIAL_NAME,
1904 IDS_FLAGS_PROTECT_SYNC_CREDENTIAL_DESCRIPTION, kOsAll, 1909 IDS_FLAGS_PROTECT_SYNC_CREDENTIAL_DESCRIPTION, kOsAll,
1905 FEATURE_VALUE_TYPE(password_manager::features::kProtectSyncCredential)}, 1910 FEATURE_VALUE_TYPE(password_manager::features::kProtectSyncCredential)},
1906 {"protect-sync-credential-on-reauth", 1911 {"protect-sync-credential-on-reauth",
1907 IDS_FLAGS_PROTECT_SYNC_CREDENTIAL_ON_REAUTH_NAME, 1912 IDS_FLAGS_PROTECT_SYNC_CREDENTIAL_ON_REAUTH_NAME,
1908 IDS_FLAGS_PROTECT_SYNC_CREDENTIAL_ON_REAUTH_DESCRIPTION, kOsAll, 1913 IDS_FLAGS_PROTECT_SYNC_CREDENTIAL_ON_REAUTH_DESCRIPTION, kOsAll,
(...skipping 435 matching lines...) Expand 10 before | Expand all | Expand 10 after
2344 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2349 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2345 2350
2346 const FeatureEntry* GetFeatureEntries(size_t* count) { 2351 const FeatureEntry* GetFeatureEntries(size_t* count) {
2347 *count = arraysize(kFeatureEntries); 2352 *count = arraysize(kFeatureEntries);
2348 return kFeatureEntries; 2353 return kFeatureEntries;
2349 } 2354 }
2350 2355
2351 } // namespace testing 2356 } // namespace testing
2352 2357
2353 } // namespace about_flags 2358 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698