Run tools/clang-format-js on chrome/browser/resources/net_internals

chrome/browser/resources/net_internals/index.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-<include src="util.js">
-<include src="table_printer.js">
-<include src="view.js">
-<include src="mouse_over_help.js">
-<include src="tab_switcher_view.js">
-<include src="import_view.js">
-<include src="capture_view.js">
-<include src="export_view.js">
-<include src="http_cache_view.js">
-<include src="hsts_view.js">
-<include src="browser_bridge.js">
-<include src="events_tracker.js">
-<include src="source_tracker.js">
-<include src="resizable_vertical_split_view.js">
-<include src="main.js">
-<include src="time_util.js">
-<include src="log_util.js">
-<include src="capture_status_view.js">
-<include src="loaded_status_view.js">
-<include src="halted_status_view.js">
-<include src="top_bar_view.js">
-<include src="dns_view.js">
-<include src="source_filter_parser.js">
-<include src="source_row.js">
-<include src="events_view.js">
-<include src="details_view.js">
-<include src="source_entry.js">
-<include src="horizontal_scrollbar_view.js">
-<include src="top_mid_bottom_view.js">
-<include src="timeline_data_series.js">
-<include src="timeline_graph_view.js">
-<include src="timeline_view.js">
-<include src="log_view_painter.js">
-<include src="log_grouper.js">
-<include src="proxy_view.js">
-<include src="quic_view.js">
-<include src="socket_pool_wrapper.js">
-<include src="sockets_view.js">
-<include src="alt_svc_view.js">
-<include src="spdy_view.js">
-<include src="modules_view.js">
-<include src="prerender_view.js">
-<include src="chromeos_view.js">
-<include src="bandwidth_view.js">
-<include src="sdch_view.js">
+// <include src="util.js">

[eroman, 2016/12/23 02:38:44]

I don't believe these changes here are correct.

[Dan Beam, 2016/12/23 02:41:24]

why do you believe these are incorrect?  what do you think is happening?

note: grit doesn't care about // comments.  clang-format does.  so these files
are still inlined.  they also have copyrights on top (as must all .js files) so
you end up going from

// <include src="blah.js">

to

// // Copyright Chromium or whatever
// more copyright
// end copyright.

... contents of blah.js ...

if I *don't* comment out these lines, bad things happen.  I can show you if
you'd like.

[Dan Beam, 2016/12/23 02:42:45]

and while i don't totally love depending on this behavior:

a) it's enforced by tooling (i.e. .js files must have a copyright)
b) it's used a little bit already
https://cs.chromium.org/search/?q=%22//+%3Cinclude+src%22&sq=package:chromium...

[Dan Beam, 2016/12/23 02:53:39]

and if you were wondering, closure_linter had hacks for this, as does the
closure *compiler* :/

it's basically our fault for putting <if|include> into source code

though at least <if> is quite helpful

+// <include src="table_printer.js">
+// <include src="view.js">
+// <include src="mouse_over_help.js">
+// <include src="tab_switcher_view.js">
+// <include src="import_view.js">
+// <include src="capture_view.js">
+// <include src="export_view.js">
+// <include src="http_cache_view.js">
+// <include src="hsts_view.js">
+// <include src="browser_bridge.js">
+// <include src="events_tracker.js">
+// <include src="source_tracker.js">
+// <include src="resizable_vertical_split_view.js">
+// <include src="main.js">
+// <include src="time_util.js">
+// <include src="log_util.js">
+// <include src="capture_status_view.js">
+// <include src="loaded_status_view.js">
+// <include src="halted_status_view.js">
+// <include src="top_bar_view.js">
+// <include src="dns_view.js">
+// <include src="source_filter_parser.js">
+// <include src="source_row.js">
+// <include src="events_view.js">
+// <include src="details_view.js">
+// <include src="source_entry.js">
+// <include src="horizontal_scrollbar_view.js">
+// <include src="top_mid_bottom_view.js">
+// <include src="timeline_data_series.js">
+// <include src="timeline_graph_view.js">
+// <include src="timeline_view.js">
+// <include src="log_view_painter.js">
+// <include src="log_grouper.js">
+// <include src="proxy_view.js">
+// <include src="quic_view.js">
+// <include src="socket_pool_wrapper.js">
+// <include src="sockets_view.js">
+// <include src="alt_svc_view.js">
+// <include src="spdy_view.js">
+// <include src="modules_view.js">
+// <include src="prerender_view.js">
+// <include src="chromeos_view.js">
+// <include src="bandwidth_view.js">
+// <include src="sdch_view.js">
 
 document.addEventListener('DOMContentLoaded', function() {
   MainView.getInstance();  // from main.js
 });