Push attributeName handling down into SVGAnimateElement

third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp

 /*
  * Copyright (C) 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
  *
  * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
  * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
  * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
  * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
  * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
  * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
  * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "core/svg/animation/SVGSMILElement.h"
 
-#include "bindings/core/v8/ExceptionStatePlaceholder.h"
 #include "bindings/core/v8/ScriptEventListener.h"
 #include "core/XLinkNames.h"
 #include "core/dom/Document.h"
 #include "core/dom/TaskRunnerHelper.h"
 #include "core/events/Event.h"
 #include "core/events/EventListener.h"
 #include "core/svg/SVGDocumentExtensions.h"
 #include "core/svg/SVGSVGElement.h"
 #include "core/svg/SVGURIReference.h"
 #include "core/svg/animation/SMILTimeContainer.h"
@@ skipping 179 matching lines @@
     }
   } else {
     // Register us with the target in the dependencies map. Any change of
     // hrefElement that leads to relayout/repainting now informs us, so we can
     // react to it.
     addReferenceTo(svgTarget);
   }
   connectEventBaseConditions();
 }
 
-static inline QualifiedName constructQualifiedName(
-    const SVGElement* svgElement,
-    const AtomicString& attributeName) {
-  ASSERT(svgElement);
-  if (attributeName.isEmpty())
-    return anyQName();
-  if (!attributeName.contains(':'))
-    return QualifiedName(nullAtom, attributeName, nullAtom);
-
-  AtomicString prefix;
-  AtomicString localName;
-  if (!Document::parseQualifiedName(attributeName, prefix, localName,
-                                    IGNORE_EXCEPTION))
-    return anyQName();
-
-  const AtomicString& namespaceURI = svgElement->lookupNamespaceURI(prefix);
-  if (namespaceURI.isEmpty())
-    return anyQName();
-
-  QualifiedName resolvedAttrName(nullAtom, localName, namespaceURI);
-  // "Animation elements treat attributeName='xlink:href' as being an alias
-  //  for targetting the 'href' attribute."
-  // https://svgwg.org/svg2-draft/types.html#__svg__SVGURIReference__href
-  if (resolvedAttrName == XLinkNames::hrefAttr)
-    return SVGNames::hrefAttr;
-  return resolvedAttrName;
-}
-
 static inline void clearTimesWithDynamicOrigins(
     Vector<SMILTimeWithOrigin>& timeList) {
   for (int i = timeList.size() - 1; i >= 0; --i) {
     if (timeList[i].originIsScript())
       timeList.remove(i);
   }
 }
 
 void SVGSMILElement::reset() {
   clearAnimatedType();
@@ skipping 13 matching lines @@
     ContainerNode* rootParent) {
   SVGElement::insertedInto(rootParent);
 
   if (!rootParent->isConnected())
     return InsertionDone;
 
   UseCounter::count(document(), UseCounter::SVGSMILElementInDocument);
   if (document().isLoadCompleted())
     UseCounter::count(&document(), UseCounter::SVGSMILElementInsertedAfterLoad);
 
-  setAttributeName(constructQualifiedName(
-      this, fastGetAttribute(SVGNames::attributeNameAttr)));
   SVGSVGElement* owner = ownerSVGElement();
   if (!owner)
     return InsertionDone;
 
   m_timeContainer = owner->timeContainer();
   ASSERT(m_timeContainer);
   m_timeContainer->setDocumentOrderIndexesDirty();
 
   // "If no attribute is present, the default begin value (an offset-value of 0)
   // must be evaluated."
   if (!fastHasAttribute(SVGNames::beginAttr))
     m_beginTimes.append(SMILTimeWithOrigin());
 
   if (m_isWaitingForFirstInterval)
     resolveFirstInterval();
 
   if (m_timeContainer)
     m_timeContainer->notifyIntervalsChanged();
 
   buildPendingResource();
 
   return InsertionDone;
 }
 
 void SVGSMILElement::removedFrom(ContainerNode* rootParent) {
   if (rootParent->isConnected()) {
     clearResourceAndEventBaseReferences();
     clearConditions();
     setTargetElement(nullptr);
-    setAttributeName(anyQName());
     animationAttributeChanged();
     m_timeContainer = nullptr;
   }
 
   SVGElement::removedFrom(rootParent);
 }
 
 SMILTime SVGSMILElement::parseOffsetValue(const String& data) {
   bool ok;
   double result = 0;
@@ skipping 186 matching lines @@
   if (attrName == SVGNames::durAttr) {
     m_cachedDur = invalidCachedTime;
   } else if (attrName == SVGNames::repeatDurAttr) {
     m_cachedRepeatDur = invalidCachedTime;
   } else if (attrName == SVGNames::repeatCountAttr) {
     m_cachedRepeatCount = invalidCachedTime;
   } else if (attrName == SVGNames::minAttr) {
     m_cachedMin = invalidCachedTime;
   } else if (attrName == SVGNames::maxAttr) {
     m_cachedMax = invalidCachedTime;
-  } else if (attrName == SVGNames::attributeNameAttr) {
-    setAttributeName(constructQualifiedName(
-        this, fastGetAttribute(SVGNames::attributeNameAttr)));
   } else if (attrName.matches(SVGNames::hrefAttr) ||
              attrName.matches(XLinkNames::hrefAttr)) {
     // TODO(fs): Could be smarter here when 'href' is specified and 'xlink:href'
     // is changed.
     SVGElement::InvalidationGuard invalidationGuard(this);
     buildPendingResource();
     if (m_targetElement)
       clearAnimatedType();
   } else if (attrName == SVGNames::beginAttr || attrName == SVGNames::endAttr) {
     if (isConnected()) {
@@ skipping 96 matching lines @@
       SVGElement* eventBase = eventBaseFor(*condition);
       if (eventBase)
         eventBase->removeEventListener(AtomicString(condition->name()),
                                        condition->eventListener(), false);
       condition->eventListener()->disconnectAnimation();
       condition->setEventListener(nullptr);
     }
   }
 }
 
-void SVGSMILElement::setAttributeName(const QualifiedName& attributeName) {
-  unscheduleIfScheduled();
-  if (m_targetElement)
-    clearAnimatedType();
-  m_attributeName = attributeName;
-  schedule();
-}
-
 void SVGSMILElement::setTargetElement(SVGElement* target) {
   unscheduleIfScheduled();
 
   if (m_targetElement) {
     // Clear values that may depend on the previous target.
     clearAnimatedType();
     disconnectSyncBaseConditions();
   }
 
   // If the animation state is not Inactive, always reset to a clear state
@@ skipping 688 matching lines @@
 DEFINE_TRACE(SVGSMILElement) {
   visitor->trace(m_targetElement);
   visitor->trace(m_timeContainer);
   visitor->trace(m_conditions);
   visitor->trace(m_syncBaseDependents);
   SVGElement::trace(visitor);
   SVGTests::trace(visitor);
 }
 
 }  // namespace blink