Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 26024003: Add mac framework dependencies to TestRunner (Closed)

Created:
7 years, 2 months ago by Shezan Baig (Bloomberg)
Modified:
7 years, 2 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add mac framework dependencies to TestRunner Right now, TestRunner is inheriting this link_setting from 'base', but this is taking advantage of a GYP bug where link_settings were propagated outside shared_library targets. The GYP bug is fixed in r1717, but in order to enable it, Blink's link_settings need to be fixed first. R=abarth@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158964

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M Source/testing/testing.gyp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Shezan Baig (Bloomberg)
Adam, this is to fix the mac link errors in: http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/90783/steps/compile/logs/stdio Thanks!
7 years, 2 months ago (2013-10-04 19:31:54 UTC) #1
abarth-chromium
lgtm
7 years, 2 months ago (2013-10-04 20:38:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbaig1@bloomberg.net/26024003/1
7 years, 2 months ago (2013-10-04 20:51:03 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-04 21:46:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbaig1@bloomberg.net/26024003/1
7 years, 2 months ago (2013-10-04 21:48:11 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-04 23:20:40 UTC) #6
Message was sent while issue was closed.
Change committed as 158964

Powered by Google App Engine
This is Rietveld 408576698