Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2619)

Unified Diff: content/renderer/browser_plugin/browser_plugin_compositing_helper.cc

Issue 26023004: aura: Allow delegated frames to be used by more than one impl layer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: frameprovider: are_layers_attached checks Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/browser_plugin/browser_plugin_compositing_helper.h ('k') | ui/compositor/layer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/browser_plugin/browser_plugin_compositing_helper.cc
diff --git a/content/renderer/browser_plugin/browser_plugin_compositing_helper.cc b/content/renderer/browser_plugin/browser_plugin_compositing_helper.cc
index c7a4758365e34bdb17dd0b5bb3148395d7f5255f..12e5f3423a1d5c68599374ed1561ce9c16496490 100644
--- a/content/renderer/browser_plugin/browser_plugin_compositing_helper.cc
+++ b/content/renderer/browser_plugin/browser_plugin_compositing_helper.cc
@@ -4,6 +4,8 @@
#include "content/renderer/browser_plugin/browser_plugin_compositing_helper.h"
+#include "cc/layers/delegated_frame_provider.h"
+#include "cc/layers/delegated_frame_resource_collection.h"
#include "cc/layers/delegated_renderer_layer.h"
#include "cc/layers/solid_color_layer.h"
#include "cc/layers/texture_layer.h"
@@ -68,11 +70,11 @@ void BrowserPluginCompositingHelper::DidCommitCompositorFrame() {
software_ack_pending_ = false;
}
- if (!delegated_layer_.get() || !ack_pending_)
+ if (!resource_collection_.get() || !ack_pending_)
return;
cc::CompositorFrameAck ack;
- delegated_layer_->TakeUnusedResourcesForChildCompositor(&ack.resources);
+ resource_collection_->TakeUnusedResourcesForChildCompositor(&ack.resources);
browser_plugin_manager_->Send(
new BrowserPluginHostMsg_CompositorFrameACK(
@@ -337,24 +339,39 @@ void BrowserPluginCompositingHelper::OnCompositorFrameSwapped(
}
DCHECK(!texture_layer_.get());
- if (!delegated_layer_.get()) {
- delegated_layer_ = cc::DelegatedRendererLayer::Create(NULL);
+
+ cc::DelegatedFrameData* frame_data = frame->delegated_frame_data.get();
+ if (!frame_data)
+ return;
+
+ DCHECK(!frame_data->render_pass_list.empty());
+ cc::RenderPass* root_pass = frame_data->render_pass_list.back();
+ gfx::Size frame_size = root_pass->output_rect.size();
+
+ if (!resource_collection_) {
+ resource_collection_ = new cc::DelegatedFrameResourceCollection;
+ // TODO(danakj): Could return resources sooner if we set a client here and
+ // listened for UnusedResourcesAreAvailable().
+ }
+ if (!frame_provider_.get() || frame_provider_->frame_size() != frame_size) {
+ frame_provider_ = new cc::DelegatedFrameProvider(
+ resource_collection_.get(), frame->delegated_frame_data.Pass());
+ if (delegated_layer_.get())
+ delegated_layer_->RemoveFromParent();
+ delegated_layer_ =
+ cc::DelegatedRendererLayer::Create(NULL, frame_provider_.get());
delegated_layer_->SetIsDrawable(true);
delegated_layer_->SetContentsOpaque(true);
-
background_layer_->AddChild(delegated_layer_);
+ } else {
+ frame_provider_->SetFrameData(frame->delegated_frame_data.Pass());
}
- cc::DelegatedFrameData *frame_data = frame->delegated_frame_data.get();
- if (!frame_data)
- return;
-
CheckSizeAndAdjustLayerBounds(
frame_data->render_pass_list.back()->output_rect.size(),
frame->metadata.device_scale_factor,
delegated_layer_.get());
- delegated_layer_->SetFrameData(frame->delegated_frame_data.Pass());
last_route_id_ = route_id;
last_output_surface_id_ = output_surface_id;
last_host_id_ = host_id;
« no previous file with comments | « content/renderer/browser_plugin/browser_plugin_compositing_helper.h ('k') | ui/compositor/layer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698