Get rid of custom code for clipboard.clearData()

Get rid of custom code for clipboard.clearData()

Get rid of custom code for clipboard.clearData() by removing clearAllData() method
in the implementation and having clearData() behave as clearAllData() if the argument
is a null string.

There is no web-exposed behavior change.

R=haraken
TEST=fast/events/clipboard-clearData.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159141

[haraken, 2013-10-04 22:41:22]

LGTM

https://codereview.chromium.org/26023003/diff/1/Source/core/dom/Clipboard.cpp
File Source/core/dom/Clipboard.cpp (right):

https://codereview.chromium.org/26023003/diff/1/Source/core/dom/Clipboard.cpp...
Source/core/dom/Clipboard.cpp:158: if (type.isNull())

To keep the current behavior, the if(type.isNull()) branch should come before
the if(!canWriteData()) branch.

[do-not-use, 2013-10-08 14:24:42]

https://codereview.chromium.org/26023003/diff/1/Source/core/dom/Clipboard.cpp
File Source/core/dom/Clipboard.cpp (right):

https://codereview.chromium.org/26023003/diff/1/Source/core/dom/Clipboard.cpp...
Source/core/dom/Clipboard.cpp:158: if (type.isNull())
On 2013/10/04 22:41:22, haraken wrote:
> 
> To keep the current behavior, the if(type.isNull()) branch should come before
> the if(!canWriteData()) branch.

Hmm, maybe I am misreading but I don't think so. The custom code was:
if (!args.Length()) {	
  clipboard->clearAllData();	
  return;	
}	
	
and Clipboard::clearAllData() was also calling if (!canWriteData()) first,
before calling m_dataObject->clearAll().

[haraken, 2013-10-08 15:24:28]

On 2013/10/08 14:24:42, Christophe Dumez wrote:
> https://codereview.chromium.org/26023003/diff/1/Source/core/dom/Clipboard.cpp
> File Source/core/dom/Clipboard.cpp (right):
> 
>
https://codereview.chromium.org/26023003/diff/1/Source/core/dom/Clipboard.cpp...
> Source/core/dom/Clipboard.cpp:158: if (type.isNull())
> On 2013/10/04 22:41:22, haraken wrote:
> > 
> > To keep the current behavior, the if(type.isNull()) branch should come
before
> > the if(!canWriteData()) branch.
> 
> Hmm, maybe I am misreading but I don't think so. The custom code was:
> if (!args.Length()) {	
>   clipboard->clearAllData();	
>   return;	
> }	
> 	
> and Clipboard::clearAllData() was also calling if (!canWriteData()) first,
> before calling m_dataObject->clearAll().

Sorry, you're right :)

[commit-bot: I haz the power, 2013-10-08 17:48:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/26023003/1

[commit-bot: I haz the power, 2013-10-08 19:05:48]

Change committed as 159141