Issue 26023002: Mutex protect SkFontMgr_DirectWrite cache.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26023002: Mutex protect SkFontMgr_DirectWrite cache. (Closed)

Created:
7 years, 2 months ago by bungeman-skia

Modified:
7 years, 2 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Mutex protect SkFontMgr_DirectWrite cache. SkFontMgr_DirectWrite is constant, except for its typeface cache. Protect this cache in the face of multiple threads. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=11615

Patch Set 1 #

Total comments: 2

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -2 lines)			Patch
	M	src/ports/SkFontHost_win_dw.cpp	View		2 chunks	+14 lines, -2 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bungeman-skia

Should fix https://code.google.com/p/skia/issues/detail?id=1561 .

7 years, 2 months ago (2013-10-04 16:31:24 UTC) #1

robertphillips

lgtm with 1 change https://codereview.chromium.org/26023002/diff/1/src/ports/SkFontHost_win_dw.cpp File src/ports/SkFontHost_win_dw.cpp (right): https://codereview.chromium.org/26023002/diff/1/src/ports/SkFontHost_win_dw.cpp#newcode115 src/ports/SkFontHost_win_dw.cpp:115: private: make fTFCacheMutex?

7 years, 2 months ago (2013-10-04 16:34:50 UTC) #2

bungeman-skia

https://codereview.chromium.org/26023002/diff/1/src/ports/SkFontHost_win_dw.cpp File src/ports/SkFontHost_win_dw.cpp (right): https://codereview.chromium.org/26023002/diff/1/src/ports/SkFontHost_win_dw.cpp#newcode115 src/ports/SkFontHost_win_dw.cpp:115: private: On 2013/10/04 16:34:50, robertphillips wrote: > make fTFCacheMutex? ...

7 years, 2 months ago (2013-10-04 17:00:14 UTC) #3

bungeman-skia

7 years, 2 months ago (2013-10-04 17:00:37 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r11615 (presubmit successful).

Expand Messages | Collapse Messages