Fixed WebglRenderingContextBase toImageData

third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

 /*
  * Copyright (C) 2009 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 74 matching lines @@
 #include "modules/webgl/WebGLUniformLocation.h"
 #include "modules/webgl/WebGLVertexArrayObject.h"
 #include "modules/webgl/WebGLVertexArrayObjectOES.h"
 #include "platform/CrossThreadFunctional.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/WaitableEvent.h"
 #include "platform/geometry/IntSize.h"
 #include "platform/graphics/GraphicsContext.h"
 #include "platform/graphics/UnacceleratedImageBufferSurface.h"
 #include "platform/graphics/gpu/AcceleratedImageBufferSurface.h"
+#include "platform/graphics/gpu/SharedGpuContext.h"
 #include "public/platform/Platform.h"
+#include "skia/ext/texture_handle.h"
 #include "wtf/CheckedNumeric.h"
 #include "wtf/Functional.h"
 #include "wtf/PtrUtil.h"
 #include "wtf/text/StringBuilder.h"
 #include "wtf/text/StringUTF8Adaptor.h"
 #include "wtf/typed_arrays/ArrayBufferContents.h"
 #include <memory>
 
 namespace blink {
 
@@ skipping 655 matching lines @@
                                                      BackBuffer)) {
     // copyRenderingResultsFromDrawingBuffer is expected to always succeed
     // because we've explicitly created an Accelerated surface and have already
     // validated it.
     NOTREACHED();
     return nullptr;
   }
   return buffer->newImageSnapshot(hint, reason);
 }
 
-ImageData* WebGLRenderingContextBase::toImageData(SnapshotReason reason) const {
-  // TODO: Furnish toImageData in webgl renderingcontext for jpeg and webp
-  // images. See crbug.com/657531.
+ImageData* WebGLRenderingContextBase::toImageData(SnapshotReason reason) {
   ImageData* imageData = nullptr;
   // TODO(ccameron): WebGL should produce sRGB images.
   // https://crbug.com/672299
-  if (this->drawingBuffer()) {
-    sk_sp<SkImage> snapshot =
-        this->drawingBuffer()
-            ->transferToStaticBitmapImage()
-            ->imageForCurrentFrame(ColorBehavior::transformToGlobalTarget());
+  if (drawingBuffer()) {
+    // For un-premultiplied data
+    imageData = paintRenderingResultsToImageData(BackBuffer);
+    if (imageData) {
+      return imageData;
+    }
+
+    int width = drawingBuffer()->size().width();
+    int height = drawingBuffer()->size().height();
+    OpacityMode opacityMode = creationAttributes().alpha() ? NonOpaque : Opaque;
+
+    drawingBuffer()->resolveAndBindForReadAndDraw();
+    gpu::gles2::GLES2Interface* gl = SharedGpuContext::gl();

[xlai (Olivia), 2017/01/02 22:50:04]

This one works for both main and worker threads.

[Ken Russell (switch to Gerrit), 2017/01/04 04:01:12]

Acknowledged.

+    SkImageInfo imageInfo = SkImageInfo::Make(
+        width, height, kRGBA_8888_SkColorType,
+        Opaque == opacityMode ? kOpaque_SkAlphaType : kPremul_SkAlphaType);
+    SkSurfaceProps disableLCDProps(0, kUnknown_SkPixelGeometry);
+    sk_sp<SkSurface> surface = SkSurface::MakeRenderTarget(
+        SharedGpuContext::gr(), SkBudgeted::kYes, imageInfo, 0,
+        Opaque == opacityMode ? nullptr : &disableLCDProps);
+    GLuint textureId = skia::GrBackendObjectToGrGLTextureInfo(
+                           surface->getTextureHandle(
+                               SkSurface::kDiscardWrite_TextureHandleAccess))
+                           ->fID;
+
+    drawingBuffer()->copyToPlatformTexture(
+        gl, textureId, GL_RGBA, GL_UNSIGNED_BYTE, 0, true, false,
+        IntPoint(0, 0), IntRect(IntPoint(0, 0), drawingBuffer()->size()),
+        BackBuffer);
+    sk_sp<SkImage> snapshot = surface->makeImageSnapshot();
     if (snapshot) {
-      imageData = ImageData::create(this->getOffscreenCanvas()->size());
-      SkImageInfo imageInfo = SkImageInfo::Make(
-          this->drawingBufferWidth(), this->drawingBufferHeight(),
-          kRGBA_8888_SkColorType, kUnpremul_SkAlphaType);
+      imageData = ImageData::create(drawingBuffer()->size());
       snapshot->readPixels(imageInfo, imageData->data()->data(),
                            imageInfo.minRowBytes(), 0, 0);
     }
   }
   return imageData;
 }
 
 namespace {
 
 // Exposed by GL_ANGLE_depth_texture
@@ skipping 6977 matching lines @@
 
 void WebGLRenderingContextBase::getHTMLOrOffscreenCanvas(
     HTMLCanvasElementOrOffscreenCanvas& result) const {
   if (canvas())
     result.setHTMLCanvasElement(canvas());
   else
     result.setOffscreenCanvas(getOffscreenCanvas());
 }
 
 }  // namespace blink