Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(241)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: third_party/WebKit/Source/modules/webgl/DEPS
Issue
2602253002
:
Fixed WebglRenderingContextBase toImageData (Closed)
Patch Set: fix error
Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
third_party/WebKit/LayoutTests/virtual/threaded/fast/idleToBlob/OffscreenCanvas-convertToBlob-webgl-main.html
third_party/WebKit/LayoutTests/virtual/threaded/fast/idleToBlob/OffscreenCanvas-convertToBlob-webgl-main-expected.html
third_party/WebKit/LayoutTests/virtual/threaded/fast/idleToBlob/OffscreenCanvas-convertToBlob-webgl-worker.html
third_party/WebKit/LayoutTests/virtual/threaded/fast/idleToBlob/OffscreenCanvas-convertToBlob-webgl-worker-expected.html
third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h
third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
third_party/WebKit/Source/modules/webgl/DEPS
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
View unified diff
|
Download patch
« no previous file with comments
|
« third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
('k') |
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h »
('j') |
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 include_rules = [
1 include_rules = [
2 "+gpu/GLES2/gl2extchromium.h",
2 "+gpu/GLES2/gl2extchromium.h",
3 "+gpu/command_buffer/client/gles2_interface.h",
3 "+gpu/command_buffer/client/gles2_interface.h",
4
"+skia/ext",
xlai (Olivia)
2017/01/02 22:50:04
I saw that "skia/ext" is allowed in https://cs.chr
I saw that "skia/ext" is allowed in
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/notifi...
. So I don't see any reasons why it cannot be allowed in modules/webgl.
Ken Russell (switch to Gerrit)
2017/01/04 04:01:12
Acknowledged.
Show quoted text
On 2017/01/02 22:50:04, xlai (Olivia) wrote: > I saw that "skia/ext" is allowed in >
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/notifi...
. > So I don't see any reasons why it cannot be allowed in modules/webgl.
Acknowledged.
4 ]
5 ]
OLD
NEW
« no previous file with comments
|
« third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
('k') |
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h »
('j') |
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp »
('J')
Issue 2602253002: Fixed WebglRenderingContextBase toImageData (Closed)
Created 3 years, 11 months ago by xlai (Olivia)
Modified 3 years, 11 months ago
Reviewers: Ken Russell (switch to Gerrit), Justin Novosad
Base URL:
Comments: 4
This is Rietveld
408576698