Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: net/url_request/url_fetcher_impl_unittest.cc

Issue 2602243002: Use TaskScheduler instead of WorkerPool in multi_threaded_cert_verifier.cc. (Closed)
Patch Set: self-review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_fetcher_impl_unittest.cc
diff --git a/net/url_request/url_fetcher_impl_unittest.cc b/net/url_request/url_fetcher_impl_unittest.cc
index 62777bfa014f3226e52c68acb9e516c212465df9..b95fe80bc83fa0b8bc81dc56067617709f50e98e 100644
--- a/net/url_request/url_fetcher_impl_unittest.cc
+++ b/net/url_request/url_fetcher_impl_unittest.cc
@@ -19,6 +19,7 @@
#include "base/location.h"
#include "base/macros.h"
#include "base/memory/ptr_util.h"
+#include "base/message_loop/message_loop.h"
#include "base/path_service.h"
#include "base/run_loop.h"
#include "base/single_thread_task_runner.h"
@@ -313,7 +314,9 @@ class FetcherTestURLRequestContextGetter : public URLRequestContextGetter {
class URLFetcherTest : public testing::Test {
public:
- URLFetcherTest() : num_upload_streams_created_(0) {}
+ URLFetcherTest()
+ : scoped_task_scheduler_(base::MessageLoop::current()),
+ num_upload_streams_created_(0) {}
static int GetNumFetcherCores() {
return URLFetcherImpl::GetNumFetcherCores();
@@ -451,6 +454,8 @@ class URLFetcherTest : public testing::Test {
test_server_->AddDefaultHandlers(base::FilePath(kDocRoot));
}
+ base::test::ScopedTaskScheduler scoped_task_scheduler_;
+
// Network thread for cross-thread tests. Most threads just use the main
// thread for network activity.
std::unique_ptr<base::Thread> network_thread_;
@@ -520,8 +525,6 @@ TEST_F(URLFetcherTest, DifferentThreadsTest) {
// Create the fetcher from a sequenced (not single-threaded) task. Verify that
// the expected response is received.
TEST_F(URLFetcherTest, SequencedTaskTest) {
- base::test::ScopedTaskScheduler scoped_task_scheduler(
- base::MessageLoop::current());
auto sequenced_task_runner =
base::CreateSequencedTaskRunnerWithTraits(base::TaskTraits());

Powered by Google App Engine
This is Rietveld 408576698