Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2602133002: [ios] Log UMA if didStartProvisionalNavigation doesn't add pending item. (Closed)
Patch Set: Changed action to histogram Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « ios/web/web_state/ui/crw_web_controller.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 994c4a276cae418a41ef764b699a9d4b3348e358..a223973912e11ec64760f00e79d8fe59e079142a 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -72106,6 +72106,19 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram
+ name="WebController.StartProvisionalNavigationExitedWithEmptyNavigationManager"
+ enum="BooleanHit">
+ <owner>eugenebut@chromium.org</owner>
+ <summary>
+ Chrome for iOS crashes in |didCommitNavigation:| if Navigation Manager is
+ empty. It's unclear how app can get into this state and one assumption is
Ilya Sherman 2017/01/06 19:50:00 nit: s/how app/how the app
Eugene But (OOO till 7-30) 2017/01/06 19:55:33 Done.
+ that didStartProvisionalNavigation: does not add a pending navigation. This
+ UMA action is logged when didStartProvisionalNavigation: fails to add a
Ilya Sherman 2017/01/06 19:50:00 nit: s/UMA action/metric
Eugene But (OOO till 7-30) 2017/01/06 19:55:34 Done.
+ pending item.
+ </summary>
+</histogram>
+
<histogram name="WebCore.Animation.CSSProperties" enum="MappedCSSProperties">
<owner>ajuma@chromium.org</owner>
<summary>
« no previous file with comments | « ios/web/web_state/ui/crw_web_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698