Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 260213002: Add lock back to SharedRendererState (Closed)

Created:
6 years, 7 months ago by boliu
Modified:
6 years, 7 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

aw: Add lock back to SharedRendererState It is true that kModeDraw will be called with UI blocked. But it is possible for kModeProcess to be called asynchronously. We don't access the state object in kModeProcess, but better be safe than sorry. BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267072

Patch Set 1 #

Patch Set 2 : comment #

Patch Set 3 : remove bvr change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M android_webview/browser/shared_renderer_state.h View 2 chunks +2 lines, -0 lines 0 comments Download
M android_webview/browser/shared_renderer_state.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
boliu
hush for review, sgurun for stamp
6 years, 7 months ago (2014-04-28 22:44:00 UTC) #1
sgurun-gerrit only
On 2014/04/28 22:44:00, boliu wrote: > hush for review, sgurun for stamp lgtm
6 years, 7 months ago (2014-04-29 01:24:44 UTC) #2
hush (inactive)
lgtm
6 years, 7 months ago (2014-04-29 17:38:48 UTC) #3
boliu
The CQ bit was checked by boliu@chromium.org
6 years, 7 months ago (2014-04-29 17:44:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/260213002/40001
6 years, 7 months ago (2014-04-29 17:44:59 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 04:43:49 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
6 years, 7 months ago (2014-04-30 04:43:49 UTC) #7
boliu
The CQ bit was checked by boliu@chromium.org
6 years, 7 months ago (2014-04-30 04:45:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/260213002/40001
6 years, 7 months ago (2014-04-30 04:45:51 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 05:01:10 UTC) #10
Message was sent while issue was closed.
Change committed as 267072

Powered by Google App Engine
This is Rietveld 408576698