Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1262)

Unified Diff: content/common/BUILD.gn

Issue 2602103003: Remove the _cpp_sources target from mojom. (Closed)
Patch Set: update/undelete comments Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/BUILD.gn ('k') | content/public/common/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/BUILD.gn
diff --git a/content/common/BUILD.gn b/content/common/BUILD.gn
index c9bb37484f8c5af1caab42d63ad29ce96c73fe43..6b784773059fcf748a2595c0653251d9beb31bf9 100644
--- a/content/common/BUILD.gn
+++ b/content/common/BUILD.gn
@@ -349,9 +349,6 @@ source_set("common") {
"//third_party/WebKit/public:blink_headers",
]
deps = [
- # This looks needless as we have :mojo_bindings in public_deps, but it's
- # needed because of allow_circular_includes_from.
- ":mojo_bindings_cpp_sources",
"//base",
"//base/third_party/dynamic_annotations",
"//build/util:webkit_version",
@@ -384,7 +381,7 @@ source_set("common") {
"//media/gpu/ipc/client",
"//media/gpu/ipc/common",
"//media/midi",
- "//media/midi:mojo_cpp_sources",
+ "//media/midi:mojo",
"//mojo/common:common_base",
"//mojo/edk/system",
"//net",
@@ -427,7 +424,7 @@ source_set("common") {
libs = []
ldflags = []
- allow_circular_includes_from = [ ":mojo_bindings_cpp_sources" ]
+ allow_circular_includes_from = [ ":mojo_bindings" ]
if (is_android && use_seccomp_bpf) {
set_sources_assignment_filter([])
« no previous file with comments | « content/browser/BUILD.gn ('k') | content/public/common/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698