Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.cpp

Issue 2601983002: [IndexedDB] Adding transaction and value support to observers (Closed)
Patch Set: added comments and bug link Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.cpp
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.cpp
index 5e80fe6adf743e87614bc8e0cd5ceeacfb82033a..f0a8ba971751e9caa7e9f391580ee6a94a56b937 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.cpp
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.cpp
@@ -31,28 +31,40 @@ ScriptValue IDBObserverChanges::records(ScriptState* scriptState) {
IDBObserverChanges* IDBObserverChanges::create(
IDBDatabase* database,
const WebVector<WebIDBObservation>& observations,
- const WebVector<int32_t>& observationIndex) {
- return new IDBObserverChanges(database, observations, observationIndex);
+ const WebVector<int32_t>& observationIndices) {
+ return new IDBObserverChanges(database, nullptr, observations,
+ observationIndices);
+}
+
+IDBObserverChanges* IDBObserverChanges::create(
+ IDBDatabase* database,
+ IDBTransaction* transaction,
+ const WebVector<WebIDBObservation>& observations,
+ const WebVector<int32_t>& observationIndices) {
+ return new IDBObserverChanges(database, transaction, observations,
+ observationIndices);
}
IDBObserverChanges::IDBObserverChanges(
IDBDatabase* database,
+ IDBTransaction* transaction,
const WebVector<WebIDBObservation>& observations,
- const WebVector<int32_t>& observationIndex)
- : m_database(database) {
- extractChanges(observations, observationIndex);
+ const WebVector<int32_t>& observationIndices)
+ : m_database(database), m_transaction(transaction) {
+ extractChanges(observations, observationIndices);
}
void IDBObserverChanges::extractChanges(
const WebVector<WebIDBObservation>& observations,
- const WebVector<int32_t>& observationIndex) {
+ const WebVector<int32_t>& observationIndices) {
// TODO(dmurph): Avoid getting and setting repeated times.
- for (const auto& idx : observationIndex)
+ for (const auto& idx : observationIndices) {
m_records
.add(observations[idx].objectStoreId,
HeapVector<Member<IDBObservation>>())
.storedValue->value.push_back(
IDBObservation::create(observations[idx]));
+ }
}
DEFINE_TRACE(IDBObserverChanges) {

Powered by Google App Engine
This is Rietveld 408576698