third_party/WebKit/Source/modules/indexeddb/IDBDatabaseCallbacks.cpp - Issue 2601983002: [IndexedDB] Adding transaction and value support to observers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBDatabaseCallbacks.cpp

Issue 2601983002: [IndexedDB] Adding transaction and value support to observers (Closed)

Patch Set: added comments and bug link Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/indexeddb/IDBDatabaseCallbacks.h ('k') | third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/indexeddb/IDBDatabaseCallbacks.cpp

diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBDatabaseCallbacks.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBDatabaseCallbacks.cpp

index 885bbbbf8681369d069f13131157e227661306df..53a33842eaef44bc77d76072cd7855e8ae120f28 100644

--- a/third_party/WebKit/Source/modules/indexeddb/IDBDatabaseCallbacks.cpp

+++ b/third_party/WebKit/Source/modules/indexeddb/IDBDatabaseCallbacks.cpp

@@ -66,9 +66,12 @@ void IDBDatabaseCallbacks::onComplete(int64_t transactionId) {

void IDBDatabaseCallbacks::onChanges(

const std::unordered_map<int32_t, std::vector<int32_t>>&

observation_index_map,

- const WebVector<WebIDBObservation>& observations) {

- if (m_database)

- m_database->onChanges(observation_index_map, observations);

+ const WebVector<WebIDBObservation>& observations,

+ const TransactionMap& transactions) {

+ if (!m_database)

+ return;

+ m_database->onChanges(observation_index_map, observations, transactions);

}

void IDBDatabaseCallbacks::connect(IDBDatabase* database) {