third_party/WebKit/Source/modules/indexeddb/WebIDBDatabaseCallbacksImpl.h - Issue 2601983002: [IndexedDB] Adding transaction and value support to observers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/indexeddb/WebIDBDatabaseCallbacksImpl.h

Issue 2601983002: [IndexedDB] Adding transaction and value support to observers (Closed)

Patch Set: Replying to comments, disallowed observing from versionchange txn Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp ('K') | « third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp ('k') | third_party/WebKit/Source/modules/indexeddb/WebIDBDatabaseCallbacksImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/indexeddb/WebIDBDatabaseCallbacksImpl.h

diff --git a/third_party/WebKit/Source/modules/indexeddb/WebIDBDatabaseCallbacksImpl.h b/third_party/WebKit/Source/modules/indexeddb/WebIDBDatabaseCallbacksImpl.h

index d1f764da56d44f33c93a000bc7b56d2e702cb05b..46a17a216cd74f9ec5734457c209814c333bdaae 100644

--- a/third_party/WebKit/Source/modules/indexeddb/WebIDBDatabaseCallbacksImpl.h

+++ b/third_party/WebKit/Source/modules/indexeddb/WebIDBDatabaseCallbacksImpl.h

@@ -32,6 +32,7 @@

#include "public/platform/modules/indexeddb/WebIDBDatabaseError.h"

#include "wtf/PassRefPtr.h"

#include "wtf/RefPtr.h"

#include <memory>

namespace blink {

@@ -49,9 +50,13 @@ class WebIDBDatabaseCallbacksImpl final : public WebIDBDatabaseCallbacks {

void onVersionChange(long long oldVersion, long long newVersion) override;

void onAbort(long long transactionId, const WebIDBDatabaseError&) override;

void onComplete(long long transactionId) override;

- void onChanges(const std::unordered_map<int32_t, std::vector<int32_t>>&

- observation_index_map,

- const WebVector<WebIDBObservation>& observations) override;

+ void onChanges(

+ const std::unordered_map<int32_t, std::vector<int32_t>>&

+ observation_index_map,

+ const WebVector<WebIDBObservation>& observations,

+ const std::unordered_map<int32_t,

+ std::pair<int64_t, std::vector<int64_t>>>&

+ transactions) override;

void detach() override;

private: