[IndexedDB] Adding transaction and value support to observers

third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/indexeddb/IDBObserverChanges.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptState.h"
 #include "bindings/core/v8/V8Binding.h"
 #include "bindings/modules/v8/ToV8ForModules.h"
@@ skipping 14 matching lines @@
     v8::Local<v8::Value> value = ToV8(it.value, context->Global(), isolate);
     map->Set(context, key, value).ToLocalChecked();
   }
   return ScriptValue::from(scriptState, map);
 }
 
 IDBObserverChanges* IDBObserverChanges::create(
     IDBDatabase* database,
     const WebVector<WebIDBObservation>& observations,
     const WebVector<int32_t>& observationIndex) {
-  return new IDBObserverChanges(database, observations, observationIndex);
+  return new IDBObserverChanges(database, nullptr, observations,
+                                observationIndex);

[cmumford, 2017/01/17 20:58:11]

Are these really observerIndices?

[dmurph, 2017/01/17 23:28:04]

Yeah, they are the indexes in the observations array that apply to this
observer. So.... observationIndex? I'll make it observationIndices.

+}
+
+IDBObserverChanges* IDBObserverChanges::create(
+    IDBDatabase* database,
+    IDBTransaction* transaction,
+    const WebVector<WebIDBObservation>& observations,
+    const WebVector<int32_t>& observationIndex) {
+  return new IDBObserverChanges(database, transaction, observations,
+                                observationIndex);
 }
 
 IDBObserverChanges::IDBObserverChanges(
     IDBDatabase* database,
+    IDBTransaction* transaction,
     const WebVector<WebIDBObservation>& observations,
     const WebVector<int32_t>& observationIndex)
-    : m_database(database) {
+    : m_database(database), m_transaction(transaction) {
   extractChanges(observations, observationIndex);
 }
 
 void IDBObserverChanges::extractChanges(
     const WebVector<WebIDBObservation>& observations,
     const WebVector<int32_t>& observationIndex) {
   // TODO(dmurph): Avoid getting and setting repeated times.
   for (const auto& idx : observationIndex)
     m_records
         .add(observations[idx].objectStoreId,
              HeapVector<Member<IDBObservation>>())
         .storedValue->value.append(IDBObservation::create(observations[idx]));
 }
 
 DEFINE_TRACE(IDBObserverChanges) {
   visitor->trace(m_database);
   visitor->trace(m_transaction);
   visitor->trace(m_records);
 }
 
 }  // namespace blink