Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 2601963002: Set needs paint property update when dirtying descendant-dependent properties. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/PaintLayer.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.cpp b/third_party/WebKit/Source/core/paint/PaintLayer.cpp
index 7a098e407c3170d03fdbc948ebb001ca222ec3f6..316bc7e57e0bc78ca5db930d6ff87defa135419e 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayer.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayer.cpp
@@ -631,6 +631,9 @@ void PaintLayer::markAncestorChainForDescendantDependentFlagsUpdate() {
if (layer->m_needsDescendantDependentFlagsUpdate)
break;
layer->m_needsDescendantDependentFlagsUpdate = true;
+
+ if (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled())
+ layer->layoutObject()->setNeedsPaintPropertyUpdate();
}
}
@@ -1012,11 +1015,6 @@ void PaintLayer::setNeedsCompositingInputsUpdate() {
// dependent flags udpate. Reduce call sites after SPv2 launch allows
/// removal of CompositingInputsUpdater.
markAncestorChainForDescendantDependentFlagsUpdate();
- if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
- // This update is needed in order to re-compute sticky position constraints,
- // not for any other reason.
- layoutObject()->setNeedsPaintPropertyUpdate();
- }
}
void PaintLayer::setNeedsCompositingInputsUpdateInternal() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698