Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2601903003: Add assert in the precompiler tree shaker to ensure that no redirecting (Closed)

Created:
3 years, 11 months ago by siva
Modified:
3 years, 11 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add assert in the precompiler tree shaker to ensure that no redirecting constructors are added as we do not expect to see any of them. BUG= R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/3db25d12bbbd50edf4aa96e73ec0184bc05e1cd7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M runtime/vm/precompiler.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
3 years, 11 months ago (2016-12-29 03:35:41 UTC) #2
regis
lgtm
3 years, 11 months ago (2016-12-29 17:03:22 UTC) #3
siva
3 years, 11 months ago (2016-12-29 18:32:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3db25d12bbbd50edf4aa96e73ec0184bc05e1cd7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698