Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1882)

Unified Diff: content/browser/shared_worker/shared_worker_service_impl.cc

Issue 2601893002: SharedWorker: Remove message forwarding mechanism (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/shared_worker/shared_worker_service_impl.cc
diff --git a/content/browser/shared_worker/shared_worker_service_impl.cc b/content/browser/shared_worker/shared_worker_service_impl.cc
index 6d8dfca611b305d605b9a706732ee94625c6f598..c350a057a6f73f32401ec7d03bca699923fefe83 100644
--- a/content/browser/shared_worker/shared_worker_service_impl.cc
+++ b/content/browser/shared_worker/shared_worker_service_impl.cc
@@ -324,14 +324,17 @@ blink::WebWorkerCreationError SharedWorkerServiceImpl::CreateWorker(
return ReserveRenderProcessToCreateWorker(std::move(pending_instance));
}
-void SharedWorkerServiceImpl::ForwardToWorker(
- const IPC::Message& message,
+void SharedWorkerServiceImpl::ConnectToWorker(
+ int route_id,
+ int sent_message_port_id,
SharedWorkerMessageFilter* filter) {
for (WorkerHostMap::const_iterator iter = worker_hosts_.begin();
iter != worker_hosts_.end();
++iter) {
- if (iter->second->FilterMessage(message, filter))
+ if (iter->second->CanHandleMessage(route_id, filter)) {
kinuko 2017/01/05 04:28:25 It feels this method doesn't need to be split from
nhiroki 2017/01/05 08:40:54 Done.
+ iter->second->Connect(route_id, sent_message_port_id, filter);
return;
+ }
}
}

Powered by Google App Engine
This is Rietveld 408576698