MacViews/a11y: Mark Views as invisible if their parents are invisible.

ui/views/accessibility/native_view_accessibility.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/accessibility/native_view_accessibility.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "ui/events/event_utils.h"
 #include "ui/gfx/native_widget_types.h"
 #include "ui/views/controls/native/native_view_host.h"
 #include "ui/views/view.h"
 #include "ui/views/widget/widget.h"
 
 namespace views {
 
+namespace {
+
+// Determine a View's visibility accounting for potentially invisible ancestors,
+// since View::visible() won't return true for descendants of invisible Views.
+bool IsViewVisible(View* view) {
+  while (view) {

[karandeepb, 2016/12/28 10:59:59]

Also a visible view with no parent would return true, which is probably
incorrect.

[Patti Lor, 2016/12/29 00:57:56]

This was fixed when replacing this method with IsDrawn() :)

+    if (!view->visible())
+      return false;
+    view = view->parent();
+  }
+  return true;
+}
+
+}  // namespace
+
 #if !defined(PLATFORM_HAS_NATIVE_VIEW_ACCESSIBILITY_IMPL)
 // static
 NativeViewAccessibility* NativeViewAccessibility::Create(View* view) {
   return new NativeViewAccessibility(view);
 }
 #endif  // !defined(PLATFORM_HAS_NATIVE_VIEW_ACCESSIBILITY_IMPL)
 
 NativeViewAccessibility::NativeViewAccessibility(View* view)
     : view_(view),
       parent_widget_(nullptr),
@@ skipping 52 matching lines @@
   view_->GetTooltipText(gfx::Point(), &description);
   data_.AddStringAttribute(ui::AX_ATTR_DESCRIPTION,
                            base::UTF16ToUTF8(description));
 
   if (view_->IsAccessibilityFocusable())
     data_.state |= (1 << ui::AX_STATE_FOCUSABLE);
 
   if (!view_->enabled())
     data_.state |= (1 << ui::AX_STATE_DISABLED);
 
-  if (!view_->visible())
+  if (!IsViewVisible(view_))

[karandeepb, 2016/12/28 10:57:10]

It seems to me that View::IsDrawn accomplishes the same thing. Think you can use
it.

[Patti Lor, 2016/12/29 00:57:56]

Oops, you're totally right. Thanks for pointing it out :D

     data_.state |= (1 << ui::AX_STATE_INVISIBLE);
 
   return data_;
 }
 
 int NativeViewAccessibility::GetChildCount() {
   int child_count = view_->child_count();
 
   std::vector<Widget*> child_widgets;
   PopulateChildWidgetVector(&child_widgets);
@@ skipping 177 matching lines @@
               child_widget_platform_node->GetDelegate());
       if (child_widget_view_accessibility->parent_widget() != widget)
         child_widget_view_accessibility->SetParentWidget(widget);
     }
 
     result_child_widgets->push_back(child_widget);
   }
 }
 
 }  // namespace views