Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2601863002: add angular analyzer to DEPS for distribution in google builds (Closed)

Created:
3 years, 12 months ago by mfairhurst
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

add angular analyzer to DEPS for distribution in google builds BUG= R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/fd6c486760eabedbce099bd27771e8c9ddfbdab9

Patch Set 1 #

Total comments: 1

Patch Set 2 : Don't use mirror for DEPS and ngAnalyzer just yet #

Patch Set 3 : Don't use mirror for DEPS and ngAnalyzer just yet #

Patch Set 4 : Update deps now that its ready to roll #

Patch Set 5 : Update deps now that its ready to roll #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M DEPS View 1 2 3 4 3 chunks +4 lines, -1 line 1 comment Download

Messages

Total messages: 12 (4 generated)
mfairhurst
3 years, 12 months ago (2016-12-28 00:28:55 UTC) #3
Bill Hesse
https://codereview.chromium.org/2601863002/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/2601863002/diff/1/DEPS#newcode181 DEPS:181: (Var("github_mirror") % "angular_analyzer_plugin") + This needs to use the ...
3 years, 11 months ago (2017-01-02 08:05:56 UTC) #4
mfairhurst
don't use mirror so we can get this merged sooner
3 years, 11 months ago (2017-01-09 19:29:50 UTC) #5
Bill Hesse
lgtm
3 years, 11 months ago (2017-01-10 17:50:07 UTC) #6
Bill Hesse
On 2017/01/10 17:50:07, Bill Hesse wrote: > lgtm The mirror is now there, so you ...
3 years, 11 months ago (2017-01-11 15:30:15 UTC) #7
mfairhurst
After a long hiatus, I'll be merging this after I get approval for this: https://github.com/dart-lang/angular_analyzer_plugin/pull/259. ...
3 years, 8 months ago (2017-03-28 23:29:59 UTC) #8
mfairhurst
Committed patchset #5 (id:80001) manually as fd6c486760eabedbce099bd27771e8c9ddfbdab9 (presubmit successful).
3 years, 8 months ago (2017-03-29 18:02:03 UTC) #10
zra
3 years, 8 months ago (2017-03-29 18:27:42 UTC) #12
Message was sent while issue was closed.
https://codereview.chromium.org/2601863002/diff/80001/DEPS
File DEPS (left):

https://codereview.chromium.org/2601863002/diff/80001/DEPS#oldcode1
DEPS:1: # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS
file
It looks like this line was removed by mistake. Please add it back.

Powered by Google App Engine
This is Rietveld 408576698