Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2135)

Unified Diff: content/public/test/test_utils.h

Issue 2601843002: Convert more test helpers to base::RunLoop, fix page title checks. (Closed)
Patch Set: Remove unneeded call. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/test_utils.h
diff --git a/content/public/test/test_utils.h b/content/public/test/test_utils.h
index 6e46fd239b1e15a0368c98839ed8c7a155789a2a..67a919c7811320bd820884d64f230ebf352b4e25 100644
--- a/content/public/test/test_utils.h
+++ b/content/public/test/test_utils.h
@@ -259,7 +259,7 @@ class InProcessUtilityThreadHelper : public BrowserChildProcessObserver {
const ChildProcessData& data) override;
int child_thread_count_;
- scoped_refptr<MessageLoopRunner> runner_;
+ std::unique_ptr<base::RunLoop> run_loop_;
std::unique_ptr<TestServiceManagerContext> shell_context_;
DISALLOW_COPY_AND_ASSIGN(InProcessUtilityThreadHelper);
@@ -300,7 +300,7 @@ class WebContentsDestroyedWatcher : public WebContentsObserver {
// Overridden WebContentsObserver methods.
void WebContentsDestroyed() override;
- scoped_refptr<MessageLoopRunner> message_loop_runner_;
+ base::RunLoop run_loop_;
DISALLOW_COPY_AND_ASSIGN(WebContentsDestroyedWatcher);
};

Powered by Google App Engine
This is Rietveld 408576698