Chromium Code Reviews| Index: PRESUBMIT.py |
| diff --git a/PRESUBMIT.py b/PRESUBMIT.py |
| index 32a16e1471d4f4ceca549c578b6aebae260fc88b..0595dcdad0d9dd063d91b9034407c359c1f35178 100644 |
| --- a/PRESUBMIT.py |
| +++ b/PRESUBMIT.py |
| @@ -751,6 +751,25 @@ def _CheckFilePermissions(input_api, output_api): |
| long_text=error.output)] |
| +def _CheckTeamTags(input_api, output_api): |
| + """Checks that OWNERS files have consistent TEAM and COMPONENT tags.""" |
| + checkteamtags_tool = input_api.os_path.join( |
| + input_api.PresubmitLocalPath(), |
| + 'tools', 'checkteamtags', 'checkteamtags.py') |
| + args = [input_api.python_executable, checkteamtags_tool, |
| + '--root', input_api.change.RepositoryRoot()] |
| + files = [f.LocalPath() for f in input_api.AffectedFiles() |
| + if input_api.os_path.basename(f.AbsoluteLocalPath()) == 'OWNERS'] |
|
stgao
2017/01/04 06:35:27
Just double check: will this also work for Windows
RobertoCN
2017/01/04 18:48:59
Done.
|
| + try: |
| + if files: |
| + input_api.subprocess.check_output(args + files) |
| + return [] |
| + except input_api.subprocess.CalledProcessError as error: |
| + return [output_api.PresubmitError( |
| + 'checkteamtags.py failed:', |
| + long_text=error.output)] |
| + |
| + |
| def _CheckNoAuraWindowPropertyHInHeaders(input_api, output_api): |
| """Makes sure we don't include ui/aura/window_property.h |
| in header files. |
| @@ -2045,6 +2064,7 @@ def _CommonChecks(input_api, output_api): |
| results.extend(_CheckNoTrinaryTrueFalse(input_api, output_api)) |
| results.extend(_CheckUnwantedDependencies(input_api, output_api)) |
| results.extend(_CheckFilePermissions(input_api, output_api)) |
| + results.extend(_CheckTeamTags(input_api, output_api)) |
| results.extend(_CheckNoAuraWindowPropertyHInHeaders(input_api, output_api)) |
| results.extend(_CheckIncludeOrder(input_api, output_api)) |
| results.extend(_CheckForVersionControlConflicts(input_api, output_api)) |