Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: PRESUBMIT.py

Issue 2601773004: Adding check for team and component tags in owners files. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/checkteamtags/OWNERS » ('j') | tools/checkteamtags/checkteamtags.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 32a16e1471d4f4ceca549c578b6aebae260fc88b..f1f799b64d4aba294f470edbf5ce9750e65f6e75 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -751,6 +751,25 @@ def _CheckFilePermissions(input_api, output_api):
long_text=error.output)]
+def _CheckTeamTags(input_api, output_api):
+ """Check that OWNERS files have consistent TEAM and COMPONENT tags."""
+ checkteamtags_tool = input_api.os_path.join(
+ input_api.PresubmitLocalPath(),
+ 'tools', 'checkteamtags', 'checkteamtags.py')
+ args = [input_api.python_executable, checkteamtags_tool,
+ '--root', input_api.change.RepositoryRoot()]
+ files = [f.LocalPath() for f in input_api.AffectedFiles()
+ if input_api.os_path.basename(f.AbsoluteLocalPath()) == 'OWNERS']
+ try:
+ if files:
+ input_api.subprocess.check_output(args + files)
+ return []
+ except input_api.subprocess.CalledProcessError as error:
+ return [output_api.PresubmitError(
+ 'checkteamtags.py failed:',
+ long_text=error.output)]
+
+
def _CheckNoAuraWindowPropertyHInHeaders(input_api, output_api):
"""Makes sure we don't include ui/aura/window_property.h
in header files.
@@ -2045,6 +2064,7 @@ def _CommonChecks(input_api, output_api):
results.extend(_CheckNoTrinaryTrueFalse(input_api, output_api))
results.extend(_CheckUnwantedDependencies(input_api, output_api))
results.extend(_CheckFilePermissions(input_api, output_api))
+ results.extend(_CheckTeamTags(input_api, output_api))
results.extend(_CheckNoAuraWindowPropertyHInHeaders(input_api, output_api))
results.extend(_CheckIncludeOrder(input_api, output_api))
results.extend(_CheckForVersionControlConflicts(input_api, output_api))
« no previous file with comments | « no previous file | tools/checkteamtags/OWNERS » ('j') | tools/checkteamtags/checkteamtags.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698