Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Unified Diff: base/profiler/native_stack_sampler.cc

Issue 2601633002: Use a common buffer across all instances for stack-copy. (Closed)
Patch Set: use common StackBuffer; update Mac native sampler Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/profiler/native_stack_sampler.cc
diff --git a/base/profiler/native_stack_sampler.cc b/base/profiler/native_stack_sampler.cc
index 968455f13e007c7b2c26290249a79883c8805d2d..32c4a7552e74861f43314ac3671e1c3e009aeb27 100644
--- a/base/profiler/native_stack_sampler.cc
+++ b/base/profiler/native_stack_sampler.cc
@@ -6,6 +6,11 @@
namespace base {
+NativeStackSampler::StackBuffer::StackBuffer(size_t buffer_size)
+ : buffer_(new unsigned char[buffer_size]), size_(buffer_size) {}
Mike Wittman 2017/05/10 01:29:56 We should fix this for alignment while we're here,
bcwhite 2017/05/10 13:50:37 Done.
+
+NativeStackSampler::StackBuffer::~StackBuffer() {}
+
NativeStackSampler::NativeStackSampler() {}
NativeStackSampler::~NativeStackSampler() {}

Powered by Google App Engine
This is Rietveld 408576698