Remove SetFinalizer from impl/memory.

impl/memory/gkvlite_utils.go

 // Copyright 2015 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package memory
 
 import (
         "bytes"
-        "runtime"
 
         "github.com/luci/gae/service/datastore"
         "github.com/luci/gkvlite"
 )
 
 func gkvCollide(o, n memCollection, f func(k, ov, nv []byte)) {
         if o != nil && !o.IsReadOnly() {
                 panic("old collection is r/w")
         }
         if n != nil && !n.IsReadOnly() {
@@ skipping 98 matching lines @@
         if *logMemCollectionFolder != "" {
                 ret = wrapTracingMemStore(ret)
         }
         return ret
 }
 
 func (ms *memStoreImpl) Snapshot() memStore {
         if ms.ro {
                 return ms
         }
-        ret := ms.s.Snapshot()
-        runtime.SetFinalizer(ret, func(s *gkvlite.Store) { go s.Close() })
-        return &memStoreImpl{ret, true}
+        return &memStoreImpl{ms.s.Snapshot(), true}
 }
 
 func (ms *memStoreImpl) GetCollection(name string) memCollection {
         coll := ms.s.GetCollection(name)
         if coll == nil {
                 return nil
         }
         return &memCollectionImpl{coll, ms.ro}
 }
 
@@ skipping 48 matching lines @@
         }
         err := mc.c.VisitItemsAscend(target, withValue, visitor)
         memoryCorruption(err)
 }
 
 func (mc *memCollectionImpl) GetTotals() (numItems, numBytes uint64) {
         numItems, numBytes, err := mc.c.GetTotals()
         memoryCorruption(err)
         return
 }