Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2466)

Unified Diff: chrome/install_static/install_details_unittest.cc

Issue 2601443002: Remove multi-install from install_static. (Closed)
Patch Set: rebase onto position 442831 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/install_static/install_details.cc ('k') | chrome/install_static/install_modes.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/install_static/install_details_unittest.cc
diff --git a/chrome/install_static/install_details_unittest.cc b/chrome/install_static/install_details_unittest.cc
index 1627028e5ba6664d923c6f675f22e78365191e0a..f921dfd6f4f841f8ff58a17dd0194988a54c6e93 100644
--- a/chrome/install_static/install_details_unittest.cc
+++ b/chrome/install_static/install_details_unittest.cc
@@ -22,7 +22,7 @@ class FakeInstallDetails : public InstallDetails {
constants.size = sizeof(constants);
constants.install_suffix = L"";
constants.default_channel_name = L"";
- constants.supports_multi_install = true;
+ constants.supported_multi_install = true;
if (kUseGoogleUpdateIntegration) {
constants.app_guid = L"testguid";
constants.channel_strategy = ChannelStrategy::FIXED;
@@ -57,68 +57,23 @@ class FakeInstallDetails : public InstallDetails {
TEST(InstallDetailsTest, GetClientStateKeyPath) {
FakeInstallDetails details;
if (kUseGoogleUpdateIntegration) {
- // Single-install.
- EXPECT_THAT(details.GetClientStateKeyPath(false),
+ EXPECT_THAT(details.GetClientStateKeyPath(),
StrEq(L"Software\\Google\\Update\\ClientState\\testguid"));
- EXPECT_THAT(details.GetClientStateKeyPath(true),
- StrEq(L"Software\\Google\\Update\\ClientState\\testguid"));
-
- // Multi-install.
- details.payload.multi_install = true;
- EXPECT_THAT(details.GetClientStateKeyPath(false),
- StrEq(L"Software\\Google\\Update\\ClientState\\testguid"));
- EXPECT_THAT(details.GetClientStateKeyPath(true),
- StrEq(std::wstring(L"Software\\Google\\Update\\ClientState\\")
- .append(kBinariesAppGuid)));
} else {
- // Single-install.
- EXPECT_THAT(details.GetClientStateKeyPath(false),
- StrEq(std::wstring(L"Software\\").append(kProductPathName)));
- EXPECT_THAT(details.GetClientStateKeyPath(true),
+ EXPECT_THAT(details.GetClientStateKeyPath(),
StrEq(std::wstring(L"Software\\").append(kProductPathName)));
-
- // Multi-install.
- details.payload.multi_install = true;
- EXPECT_THAT(details.GetClientStateKeyPath(false),
- StrEq(std::wstring(L"Software\\").append(kProductPathName)));
- EXPECT_THAT(details.GetClientStateKeyPath(true),
- StrEq(std::wstring(L"Software\\").append(kBinariesPathName)));
}
}
TEST(InstallDetailsTest, GetClientStateMediumKeyPath) {
FakeInstallDetails details;
if (kUseGoogleUpdateIntegration) {
- // Single-install.
- EXPECT_THAT(
- details.GetClientStateMediumKeyPath(false),
- StrEq(L"Software\\Google\\Update\\ClientStateMedium\\testguid"));
EXPECT_THAT(
- details.GetClientStateMediumKeyPath(true),
+ details.GetClientStateMediumKeyPath(),
StrEq(L"Software\\Google\\Update\\ClientStateMedium\\testguid"));
-
- // Multi-install.
- details.payload.multi_install = true;
- EXPECT_THAT(
- details.GetClientStateMediumKeyPath(false),
- StrEq(L"Software\\Google\\Update\\ClientStateMedium\\testguid"));
- EXPECT_THAT(
- details.GetClientStateMediumKeyPath(true),
- StrEq(std::wstring(L"Software\\Google\\Update\\ClientStateMedium\\")
- .append(kBinariesAppGuid)));
} else {
- // Single-install.
- EXPECT_THAT(details.GetClientStateKeyPath(false),
- StrEq(std::wstring(L"Software\\").append(kProductPathName)));
- EXPECT_THAT(details.GetClientStateKeyPath(true),
- StrEq(std::wstring(L"Software\\").append(kProductPathName)));
-
- // Multi-install.
- details.payload.multi_install = true;
- EXPECT_THAT(details.GetClientStateKeyPath(false),
+ EXPECT_THAT(details.GetClientStateKeyPath(),
StrEq(std::wstring(L"Software\\").append(kProductPathName)));
- EXPECT_THAT(details.GetClientStateKeyPath(true),
- StrEq(std::wstring(L"Software\\").append(kBinariesPathName)));
}
}
« no previous file with comments | « chrome/install_static/install_details.cc ('k') | chrome/install_static/install_modes.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698