Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: chrome/install_static/install_modes.h

Issue 2601443002: Remove multi-install from install_static. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file declares constants that describe specifics of a Chromium-based 5 // This file declares constants that describe specifics of a Chromium-based
6 // browser's branding and modes of installation. 6 // browser's branding and modes of installation.
7 // 7 //
8 // A browser's brand comprises all identifying markings that distinguish it from 8 // A browser's brand comprises all identifying markings that distinguish it from
9 // a browser produced by another party. Chromium has remnants of both the 9 // a browser produced by another party. Chromium has remnants of both the
10 // Chromium and Google Chrome brands. 10 // Chromium and Google Chrome brands.
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 // and user data directory paths. May be empty if no such dir is to be used. 45 // and user data directory paths. May be empty if no such dir is to be used.
46 extern const wchar_t kCompanyPathName[]; 46 extern const wchar_t kCompanyPathName[];
47 47
48 // The brand-specific product name to be included as a component of the install 48 // The brand-specific product name to be included as a component of the install
49 // and user data directory paths. 49 // and user data directory paths.
50 extern const wchar_t kProductPathName[]; 50 extern const wchar_t kProductPathName[];
51 51
52 // The length, in characters, of kProductPathName not including the terminator. 52 // The length, in characters, of kProductPathName not including the terminator.
53 extern const size_t kProductPathNameLength; 53 extern const size_t kProductPathNameLength;
54 54
55 // The GUID with which the brand's multi-install binaries are registered with 55 // The GUID with which the brand's multi-install binaries were registered with
huangs 2016/12/27 20:04:22 Add "(legacy)" for multi-install? Same below.
grt (UTC plus 2) 2017/01/02 12:58:44 Done.
56 // Google Update. Must be empty if the brand does not integrate with Google 56 // Google Update. Must be empty if the brand does not integrate with Google
57 // Update. 57 // Update.
58 extern const wchar_t kBinariesAppGuid[]; 58 extern const wchar_t kBinariesAppGuid[];
59 59
60 // The name of the registry key in which data for the brand's multi-install 60 // The name of the registry key in which data for the brand's multi-install
61 // binaries are stored. Must be empty if the brand integrates with Google 61 // binaries were stored. Must be empty if the brand integrates with Google
62 // Update. 62 // Update.
63 extern const wchar_t kBinariesPathName[]; 63 extern const wchar_t kBinariesPathName[];
64 64
65 // A brand's collection of install modes. 65 // A brand's collection of install modes.
66 extern const InstallConstants kInstallModes[]; 66 extern const InstallConstants kInstallModes[];
67 67
68 // The following convenience functions behave conditionally on whether or not 68 // The following convenience functions behave conditionally on whether or not
69 // the brand uses Chrome's integration with Google Update. For brands that do 69 // the brand uses Chrome's integration with Google Update. For brands that do
70 // not (e.g., Chromium), they return something like "Software\Chromium" or 70 // not (e.g., Chromium), they return something like "Software\Chromium" or
71 // "Software\Chromium Binaries". Otherwise, for brands that do integrate with 71 // "Software\Chromium Binaries". Otherwise, for brands that do integrate with
72 // Google Update, they return something like 72 // Google Update, they return something like
73 // "Software\Google\Update\ClientState{Medium}\<guid>" where "<guid>" is either 73 // "Software\Google\Update\ClientState{Medium}\<guid>" where "<guid>" is either
74 // |mode|'s appguid or the brand's kBinariesAppGuid. 74 // |mode|'s appguid or the brand's kBinariesAppGuid.
75 std::wstring GetClientStateKeyPath(const wchar_t* app_guid); 75 std::wstring GetClientStateKeyPath(const wchar_t* app_guid);
76 std::wstring GetBinariesClientStateKeyPath(); 76 std::wstring GetBinariesClientStateKeyPath();
huangs 2016/12/27 20:04:22 Looks like: - GetBinariesClientStateKeyPath() - Ge
grt (UTC plus 2) 2017/01/02 12:58:45 Good catch. I left these in because I think I'll h
77 std::wstring GetClientStateMediumKeyPath(const wchar_t* app_guid); 77 std::wstring GetClientStateMediumKeyPath(const wchar_t* app_guid);
78 std::wstring GetBinariesClientStateMediumKeyPath(); 78 std::wstring GetBinariesClientStateMediumKeyPath();
79 79
80 } // namespace install_static 80 } // namespace install_static
81 81
82 #endif // CHROME_INSTALL_STATIC_INSTALL_MODES_H_ 82 #endif // CHROME_INSTALL_STATIC_INSTALL_MODES_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698