Issue 260143002: Simplify empty-clip check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 260143002: Simplify empty-clip check. (Closed)

Created:
6 years, 7 months ago by mtklein_C

Modified:
6 years, 7 months ago

Reviewers:
f(malita), mtklein, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Simplify empty-clip check. No measurable playback speed difference, but simpler code. This makes sense: I'm seeing SkRecordDraw at ~0.25% of playback cost. We can pretty much do whatever we want in there for free if it helps avoid real work. BUG=skia:2378 Committed: http://code.google.com/p/skia/source/detail?r=14419

Patch Set 1 #

Patch Set 2 : prune #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -16 lines)			Patch
	M	src/record/SkRecordDraw.cpp	View	1	4 chunks	+2 lines, -16 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/260143002/20001

6 years, 7 months ago (2014-04-28 18:49:46 UTC) #5

Message was sent while issue was closed.

Change committed as 14419

Expand Messages | Collapse Messages