Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: test/test262/testcfg.py

Issue 2601393002: [test] Allow command-line flags to be turned on per test262 test (Closed)
Patch Set: Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/test262/test262.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/test262/testcfg.py
diff --git a/test/test262/testcfg.py b/test/test262/testcfg.py
index d8123968fca0578e35855b0192e580944322656f..0f226a4147c445cc5136abe747c5429e83440e6a 100644
--- a/test/test262/testcfg.py
+++ b/test/test262/testcfg.py
@@ -131,7 +131,7 @@ class Test262TestSuite(testsuite.TestSuite):
def GetFlagsForTestCase(self, testcase, context):
return (testcase.flags + context.mode_flags + self.harness +
- self.GetIncludesForTest(testcase) + ["--harmony"] +
+ self.GetIncludesForTest(testcase) +
(["--module"] if "module" in self.GetTestRecord(testcase) else []) +
[os.path.join(self.testroot, testcase.path + ".js")] +
(["--throws"] if "negative" in self.GetTestRecord(testcase)
@@ -139,7 +139,8 @@ class Test262TestSuite(testsuite.TestSuite):
(["--allow-natives-syntax"]
if "detachArrayBuffer.js" in
self.GetTestRecord(testcase).get("includes", [])
- else []))
+ else []) +
+ ([flag for flag in testcase.outcomes if flag.startswith("--")]))
Michael Achenbach 2017/01/05 13:34:42 Maybe add an access method for this in testcase. A
Dan Ehrenberg 2017/01/05 15:36:11 I'm a little reluctant to go and touch testcase, w
def _VariantGeneratorFactory(self):
return Test262VariantGenerator
@@ -205,7 +206,9 @@ class Test262TestSuite(testsuite.TestSuite):
if (statusfile.FAIL_SLOPPY in testcase.outcomes and
"--use-strict" not in testcase.flags):
return outcome != statusfile.FAIL
- return not outcome in (testcase.outcomes or [statusfile.PASS])
+ return not outcome in ([outcome for outcome in testcase.outcomes
+ if not outcome.startswith('--')]
+ or [statusfile.PASS])
def PrepareSources(self):
# The archive is created only on swarming. Local checkouts have the
« no previous file with comments | « test/test262/test262.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698