chrome/test/data/extensions/api_test/automation/tests/tabs/location.js - Issue 2601333002: Update json_schema_compiler to handle the Automation extension API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/automation/tests/tabs/location.js

Issue 2601333002: Update json_schema_compiler to handle the Automation extension API (Closed)

Patch Set: Rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/automation/tests/tabs/line_start_offsets.js ('k') | chrome/test/data/extensions/api_test/automation/tests/tabs/location2.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/automation/tests/tabs/location.js

diff --git a/chrome/test/data/extensions/api_test/automation/tests/tabs/location.js b/chrome/test/data/extensions/api_test/automation/tests/tabs/location.js

index a4e48a51153004add7dbfb4222e6f5198e41cb22..628d2eef2f61d23b17004dd063cb3a8881867eb5 100644

--- a/chrome/test/data/extensions/api_test/automation/tests/tabs/location.js

+++ b/chrome/test/data/extensions/api_test/automation/tests/tabs/location.js

@@ -5,7 +5,7 @@

var allTests = [

function testLocation() {

function assertOkButtonLocation(event) {

- var okButton = rootNode.find({ role: RoleType.button,

+ var okButton = rootNode.find({ role: RoleType.BUTTON,

attributes: { name: 'Ok' }});

assertTrue('location' in okButton);

@@ -25,7 +25,7 @@ var allTests = [

assertTrue('width' in okButton.location, 'no width in location');

rootNode.addEventListener(

- EventType.childrenChanged, assertOkButtonLocation);

+ EventType.CHILDREN_CHANGED, assertOkButtonLocation);

chrome.tabs.executeScript({ 'code':

'document.querySelector("button")' +

'.setAttribute("style", "position: absolute; left: 100; top: 200; ' +